9721 - In a menu with an RDF datasource you can execute the wrong JS

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[davidm]

> >
> > If you go to the bookmarks menu and select "Add Current page", the JS
> > for both menu item(AddBookmark )and the datasource( OpenBookmarkUrl )
> > appear to be executed. This seems wrong to me.
>
> Bug joki and saari about event bubbling. Both handlers are firing
> because the event is bubbling out from the "Add Bookmark" menu item up
> to the top-level handler. Hyatt sez all you probably need to do is
> change the "Add Bookmark" menu to return false.
>
> chris

I tried returing false and it doesn't help. This also happens in the Tasks menu.
I think it would be bad form to require all functions associated with a menu to
be forced to return a given result.

Comment 1

[joki (gone)]

Well the bug which keeps you from preventing bubbling is mine and its slated
for checkin after the tree opens for M9.  As far as having all menu handler
return a given value (and its not actually return a value in this case, its
call a function to stop the bubbling), its either that or we have to have a
proxy function through which all menu event hanlders work since these events
are flowing through the DOM event model and, as such, will continue all the way
up the content tree unless told not to.

Comment 2

[joki (gone)]

I believe this is long since gone.  Menu's function differently now and 
cancelBubble works so I don't think there's anything left to do in this bug.

Comment 3

[John Unruh]

Verified per joki's comments.