972144 - Requesting "sync now" while identity manager is still initializing causes error notification to appear.

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

STR:
* After restarting Fx with a user configured for Sync, select "Sync Now"

Actual:
* A yellow notification box tells you that sync failed with an unknown error, and displays a button where you can open sync prefs.

Expected:
* No error notification is displayed, and sync starts ASAP.

Note that bug 972129 is to ensure the sync starts ASAP - this bug is just about the error notification.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0002-Bug-972144-don-t-show-error-notification-for-LOGIN_F.patch

Simple patch that causes browser-syncui to ignore LOGIN_FAILED_NOT_READY errors.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8375257 [details] [diff] [review]
0002-Bug-972144-don-t-show-error-notification-for-LOGIN_F.patch

Review of attachment 8375257 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/56c33addbd2f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/56c33addbd2f

Comment 5

[Tracy Walker [:tracy]]

Verified fixed on latest Nightly. Confirmed that it still affects Fx29.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8375257 [details] [diff] [review]
0002-Bug-972144-don-t-show-error-notification-for-LOGIN_F.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): FxA Sync
User impact if declined: Sync may report errors when there aren't any
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): None
String or IDL/UUID changes made by this patch: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b059913adf9c