972228 - Verify default file content in non-distribution test

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Not all patches in https://wiki.mozilla.org/Gaia/Build/Refactoring_Plan#app-makefile have tests for default file (if there is no distribution/customization). 

We need to ensure that.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR

Add simple build test scripts for apps and verify manifest.webapp in application.zip file.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Also fixed Gbu failures.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8547918 [details] [review]
Gaia PR

r=gduan,
Thanks you to add build integration tests to each app, that'll be a good start.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Thanks Let's land it.

https://github.com/mozilla-b2g/gaia/commit/95f59b145ef9de9797c847e84373fdc47b65fb25

Comment 5

[Kevin Grandon :kgrandon]

Reverted for breaking Gij tests as seen in the gaia-try run: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=0c596dedf6d4

Revert: https://github.com/mozilla-b2g/gaia/commit/20359cdf6abd74df3bc531bf2a797e6354579352

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR fix

Found bug in webapp-optimize.js, patch fixed!
George, could you take a look to it? Thanks!

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8550037 [details] [review]
Gaia PR fix

I should review it more carefully. Thanks for your quick fix! r=gduan.

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Gaia-try is green. https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=671b8d7bd309

Landed in master!

https://github.com/mozilla-b2g/gaia/commit/59e981bb6d9d4109a0fc85b27a9d4809930468bf