Closed Bug 972228 Opened 6 years ago Closed 5 years ago

Verify default file content in non-distribution test

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timdream, Assigned: rickychien)

References

()

Details

Attachments

(2 files)

Not all patches in https://wiki.mozilla.org/Gaia/Build/Refactoring_Plan#app-makefile have tests for default file (if there is no distribution/customization). 

We need to ensure that.
Component: Gaia → Gaia::Build
Attached file Gaia PR
Add simple build test scripts for apps and verify manifest.webapp in application.zip file.
Attachment #8547918 - Flags: review?(gduan)
Assignee: nobody → ricky060709
Status: NEW → ASSIGNED
Also fixed Gbu failures.
Comment on attachment 8547918 [details] [review]
Gaia PR

r=gduan,
Thanks you to add build integration tests to each app, that'll be a good start.
Attachment #8547918 - Flags: review?(gduan) → review+
Thanks Let's land it.

https://github.com/mozilla-b2g/gaia/commit/95f59b145ef9de9797c847e84373fdc47b65fb25
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Reverted for breaking Gij tests as seen in the gaia-try run: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=0c596dedf6d4

Revert: https://github.com/mozilla-b2g/gaia/commit/20359cdf6abd74df3bc531bf2a797e6354579352
Status: RESOLVED → REOPENED
Flags: needinfo?(ricky060709)
Resolution: FIXED → ---
Attached file Gaia PR fix
Found bug in webapp-optimize.js, patch fixed!
George, could you take a look to it? Thanks!
Flags: needinfo?(ricky060709)
Attachment #8550037 - Flags: review?(gduan)
Comment on attachment 8550037 [details] [review]
Gaia PR fix

I should review it more carefully. Thanks for your quick fix! r=gduan.
Attachment #8550037 - Flags: review?(gduan) → review+
Gaia-try is green. https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=671b8d7bd309

Landed in master!

https://github.com/mozilla-b2g/gaia/commit/59e981bb6d9d4109a0fc85b27a9d4809930468bf
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.