Closed Bug 972246 Opened 6 years ago Closed 6 years ago

[MediaEncoder] OmxVideoTrackEncoder cannot be stopped.

Categories

(Core :: Audio/Video: Recording, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jhlin, Assigned: jhlin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
More description please
(In reply to C.J. Ku[:CJKu] from comment #1)
> More description please

mEosSetInEncoder should be be set in OmxVideoTrackEncoder::GetEncodedTrack() only after EOS signal is sent to OMXVideoEncoder but current implementation fails to check the return value of the signaling action. When input buffers are full, OmxVideoTrackEncoder is supposed to retry (with EOS signal) again. But since mEosSetInEncoder is incorrectly set already, EOS signal will never be passed to OMXVideoEncoder so it just keeps going.
Don't set mEosSetInEncoder unless EOS is actually sent to OMXVideoEncoder.
Attachment #8375411 - Flags: review?(roc)
Update commit message and carry the r+ from roc.
Attachment #8375411 - Attachment is obsolete: true
Attachment #8377336 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/b1a1ebc98ef6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Component: Video/Audio → Video/Audio: Recording
You need to log in before you can comment on or make changes to this bug.