972246 - [MediaEncoder] OmxVideoTrackEncoder cannot be stopped.

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Comment 1

[u459114]

More description please

Comment 2

[John Lin [:jhlin][:jolin]]

(In reply to C.J. Ku[:CJKu] from comment #1)
> More description please

mEosSetInEncoder should be be set in OmxVideoTrackEncoder::GetEncodedTrack() only after EOS signal is sent to OMXVideoEncoder but current implementation fails to check the return value of the signaling action. When input buffers are full, OmxVideoTrackEncoder is supposed to retry (with EOS signal) again. But since mEosSetInEncoder is incorrectly set already, EOS signal will never be passed to OMXVideoEncoder so it just keeps going.

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Keep sending EOS signal until OMXVideoEncoder gets it.

Don't set mEosSetInEncoder unless EOS is actually sent to OMXVideoEncoder.

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: Keep sending EOS signal until OMXVideoEncoder gets it.

Update commit message and carry the r+ from roc.

Comment 5

[John Lin [:jhlin][:jolin]]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=7e2f6dd6a678

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b1a1ebc98ef6

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b1a1ebc98ef6