972310 - Set a suitable layer size for css scale animation/transition

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Come from https://bugzilla.mozilla.org/show_bug.cgi?id=945082#c106

Set the scale value to:
If the minimum scale >= 1.0f, use it; if the maximum <= 1.0f, use it; otherwise use 1.0f.

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: set a suitable scale value for css animation, r=roc

try server result

https://tbpl.mozilla.org/?tree=Try&rev=836f66e72511

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

please land attachment 8375433 [details] [diff] [review]

Comment 3

[Ryan VanderMeulen [:RyanVM]]

This doesn't have review AFAICT.

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

The attachment 8372391 [details] [diff] [review] has reviewed. See bug 945082. This attachment 8375433 [details] [diff] [review] comes from attachment 8372391 [details] [diff] [review]. I create this bug for just committing the patch.

Actually, I have rebased this patch and modified one comment in this patch. Does it need to be reviewed again?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Jerry Shih[:jerry] from comment #4)
> Actually, I have rebased this patch and modified one comment in this patch.
> Does it need to be reviewed again?

No, trivial changes usually do not require re-review.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/940b00462eb7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/940b00462eb7