Test for changes of the revision value in payloads

NEW
Unassigned

Status

()

Toolkit
Telemetry
4 years ago
2 years ago

People

(Reporter: rvitillo, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We should have a test to check if the prefix of the revision value in Telemetry's payloads is unchanged in order to avoid to break server-side code that depends on it.
(Reporter)

Updated

4 years ago
Assignee: nobody → rvitillo
(Reporter)

Comment 1

4 years ago
Created attachment 8375455 [details] [diff] [review]
Test for changes of the revision value in payloads, v1
Attachment #8375455 - Flags: review?(dteller)
Comment on attachment 8375455 [details] [diff] [review]
Test for changes of the revision value in payloads, v1

Review of attachment 8375455 [details] [diff] [review]:
-----------------------------------------------------------------

So what does this guarantee exactly?
Attachment #8375455 - Flags: review?(dteller)
(Reporter)

Updated

4 years ago
Flags: needinfo?(mreid)

Comment 3

4 years ago
What we're looking to detect is a revision URL that will be rejected by the server code.

Prior to bug 960571 landing, all the revision URLs began with "http://" so the server code validated accordingly.  See:
https://github.com/mozilla/telemetry-server/blob/1cc4dafa2d2906defd351b609c818e60135655cc/revision_cache.py#L30

The change to "https://" caused Telemetry submissions to be rejected due to invalid revision.

The server code has been updated to accept both http and https now:
https://github.com/mozilla/telemetry-server/blob/1b8c1fb963d87dcccb9849f03a3b10587938e6ab/telemetry/revision_cache.py#L31

But we want to make sure that we don't submit revisions that will be rejected on the server side in the future.
Flags: needinfo?(mreid)
(Reporter)

Updated

2 years ago
Assignee: rvitillo → nobody
You need to log in before you can comment on or make changes to this bug.