Closed
Bug 972346
Opened 11 years ago
Closed 11 years ago
mozbase - devicemanagerSUT - During _waitForRebootPing, do not accept multiple times
Categories
(Testing :: Mozbase, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Unassigned)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
941 bytes,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
Bug 964516 introduced a regression in OSX where the reboot callback failed to connect. The current behavior works on Linux but falls over on OSX. I've tested this patch with both OSX and Linux and it works for me.
I tried everything else under the sun and nothing worked. The only remaining issue was this change that was introduced in bug 964516.
Attachment #8375479 -
Flags: review?(wlachance)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8375479 [details] [diff] [review]
reboot-callback.patch
This makes sense -- if recv times out and returns nothing, we should not try to accept another connection. Instead, we should try again to read data from the one we have.
Attachment #8375479 -
Flags: review?(wlachance) → review+
|
Reporter | |
Comment 2•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•