Closed
Bug 972422
Opened 10 years ago
Closed 10 years ago
Bump mock timeout
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(1 file, 1 obsolete file)
1.30 KB,
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
This happens for some mock commands: command timed out: 1200 seconds without output, attempting to kill SIGKILL failed to kill process using fake rc=-1 program finished with exit code -1 remoteFailed: [Failure instance: Traceback from remote host -- Traceback (most recent call last): Failure: exceptions.RuntimeError: SIGKILL failed to kill process ]
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8375584 -
Flags: review?(bhearsum)
Comment 3•10 years ago
|
||
Comment on attachment 8375584 [details] [diff] [review] retry when mock times out Review of attachment 8375584 [details] [diff] [review]: ----------------------------------------------------------------- I understand why we want these for MockInstall, as that's subject to network failures, but why do we want it for init or reset? If we start retrying things like that, we should start retrying purge builds, clobberer, etc. too, I think.
Assignee | ||
Comment 4•10 years ago
|
||
We talked about this offline and found that the error is not related to spot disconnects. The error comes from the slave when it tries to kill mock but unable to do so. This happens when you try to stop a build when mock install is running -- it won't stop. Probably it's related to the fact that mock is a suid program. I'm going to update the patch and just bump the timeuot.
Summary: Retry preRun mock commands on time out → Bump mock timeout
Assignee | ||
Comment 5•10 years ago
|
||
default is 1200 (from https://hg.mozilla.org/build/buildbotcustom/file/5d08b50a1531/steps/mock.py#l218)
Attachment #8375584 -
Attachment is obsolete: true
Attachment #8375584 -
Flags: review?(bhearsum)
Assignee | ||
Updated•10 years ago
|
Attachment #8375787 -
Flags: review?(bhearsum)
Comment 6•10 years ago
|
||
Comment on attachment 8375787 [details] [diff] [review] bump timeout Review of attachment 8375787 [details] [diff] [review]: ----------------------------------------------------------------- Might be worth bumping the default for MockInstall instead or in addition?
Attachment #8375787 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8375787 [details] [diff] [review] bump timeout https://hg.mozilla.org/build/buildbotcustom/rev/2b7e56065832
Attachment #8375787 -
Flags: checked-in+
Assignee | ||
Comment 8•10 years ago
|
||
in production
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•