972447 - Allow stricter substring filtering in the console output

Status: RESOLVED WORKSFORME

(DevTools :: Console, defect, P3)

Description

[Codacoder]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140127194636

Steps to reproduce:

Tried to filter the console output


Actual results:

Filter found some lines but did not filter out some lines that it should have


Expected results:

If I enter "X : * :" then ONLY lines containing that exact text should be left visible.  Correct? I'm seeing "X : INIT :" included in the output.

Note: there are hundreds of lines that contain the rogue text, so the filter is getting close to the right output, but not perfect.

I cannot say if it's not displaying lines that it should be displaying - didn't test that.

Comment 1

[Codacoder]

Should have been more clear - only tested in FF30.

Comment 2

[Mihai Sucan [:msucan]]

Russ, thanks for your bug report, however I cannot reproduce the bug with Firefox nightlies. Can you please provide more detailed steps to reproduce?

Comment 3

[Codacoder]

Attachment: bad-filtering.png

Best I can do is to provide a screenshot.  Let me know if this isn't enough.

Comment 4

[Mihai Sucan [:msucan]]

Up-to-date Firefox nightly (Linux): https://i.imgur.com/3IPVUkW.png - works for me. You can see the messages I added to the console in the scratchpad window.

Maybe this is a windows-only bug. Paul, can you please try to repro this bug? Thanks!

Comment 5

[Codacoder]

Mihai: notice in my image that the errant line has "initQueryCache" following the " * ".  please test with that combination.

Aside: While I was checking my latest nightly I got this https://crash-stats.mozilla.com/report/index/15e84a3a-5d34-44c9-a996-8cff82140225 - unrelated, I think.

Comment 6

[Mihai Sucan [:msucan]]

(In reply to Russ from comment #5)
> Mihai: notice in my image that the errant line has "initQueryCache"
> following the " * ".  please test with that combination.

Eh, I missed that. Whatever you type is a bunch of words. Messages are displayed if any of the word you type matches in the message. We do substring matching, so initQuery matches INIT.

This is working as expected.


> Aside: While I was checking my latest nightly I got this
> https://crash-stats.mozilla.com/report/index/15e84a3a-5d34-44c9-a996-
> 8cff82140225 - unrelated, I think.

Unrelated indeed, it is a JS JIT crasher. Maybe you should file a bug report for this.

Comment 7

[Codacoder]

That (IMO) is a poor choice of algorithm... oh well.  Thanks anyway.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

This was probably fixed when we made the new frontend.