972449 - "Hide titlebar" does not hide the titlebar.

Status: RESOLVED WONTFIX

(Firefox :: Untriaged, defect)

Description

[merfius]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140205040203

Steps to reproduce:

Customize → Hide titlebar


Actual results:

http://i.imgur.com/RLSeaCJ.png


Expected results:

http://i.imgur.com/SHBSD7w

Comment 1

[:Gijs (he/him)]

I'm not sure what this bug is trying to say. The title disappears and is also gone in your screenshot; that is the point of what it is doing. What exactly is the problem you're trying to describe?

Comment 2

[merfius]

"titlebar" refers to the entire bar, not simply the title. https://en.wikipedia.org/wiki/Title_bar

When the "hide titlebar" option is enabled, the entire titlebar (all the space above the tabs, i.e. the row that the caption buttons is on) should be hidden.  However, it's not.
Perhaps this will clarify further: http://i.imgur.com/2LdyYuH.png

Either the "hide titlebar" option should perform as #titlebar{display:none!important;} once did, or the option should be renamed.

Comment 3

[:Gijs (he/him)]

(In reply to merfius from comment #2)
> "titlebar" refers to the entire bar, not simply the title.
> https://en.wikipedia.org/wiki/Title_bar
> 
> When the "hide titlebar" option is enabled, the entire titlebar (all the
> space above the tabs, i.e. the row that the caption buttons is on) should be
> hidden.  However, it's not.
> Perhaps this will clarify further: http://i.imgur.com/2LdyYuH.png
> 
> Either the "hide titlebar" option should perform as
> #titlebar{display:none!important;} once did, or the option should be renamed.

That isn't the understanding that we're using it under. The option is provided for people who do want to see the page title above the tabs (ie when we "Show" the title bar), and to hide the page title and move the tabs up in the titlebar when hiding the title. Naming the button "show/hide title" doesn't seem any clearer. The image provided with the button in this case also helps, as it still shows the window controls.

If it helps you to think about it, the titlebar effectively becomes as big as the tabbar, and they overlap completely. From that perspective, the 'title bar' is hidden by the tab bar - we just choose to still show window controls because users expect them to appear, whether or not the title is shown in a separate 'title bar'.

We don't intend to have an option to remove the window controls, nor will we remove the margin above the tabs in restored windows because it'd remove the dragging affordance to move the window around.

As it is currently phrased, I believe this is something we WONTFIX.