972459 - Windows sandbox buildingbroke after porting some LOCAL_INCLUDES variables to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brian R. Bondy [:bbondy]]

+++ This bug was initially created as a clone of Bug #968631 +++

Windows sandbox buildingbroke after porting some LOCAL_INCLUDES variables to moz.build.

Patch coming soon

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: bug972459_sandboxbuild.diff

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 8375672 [details] [diff] [review]
bug972459_sandboxbuild.diff

Review of attachment 8375672 [details] [diff] [review]:
-----------------------------------------------------------------

Think I need a win check too, will include in next patch

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: bug972459_sandboxbuild.diff

Comment 4

[(no longer active)]

Comment on attachment 8375678 [details] [diff] [review]
bug972459_sandboxbuild.diff

Review of attachment 8375678 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/app/moz.build
@@ +22,5 @@
>      '/xpcom/base',
>  ]
> +
> +if CONFIG['MOZ_CONTENT_SANDBOX'] and CONFIG['OS_ARCH'] == 'WINNT':
> +    LOCAL_INCLUDES += [

Can you please add a comment saying why these are needed, even though these directories do not have any headers inside them?  That should hopefully help the next person not get confused and mess up with these again!

Comment 5

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b18f669df651

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b18f669df651