Closed Bug 972459 Opened 8 years ago Closed 8 years ago

Windows sandbox buildingbroke after porting some LOCAL_INCLUDES variables to moz.build

Categories

(Firefox Build System :: General, defect)

x86
Windows 8
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #968631 +++

Windows sandbox buildingbroke after porting some LOCAL_INCLUDES variables to moz.build.

Patch coming soon
Attached patch bug972459_sandboxbuild.diff (obsolete) — Splinter Review
Attachment #8375672 - Flags: review?(ehsan)
Comment on attachment 8375672 [details] [diff] [review]
bug972459_sandboxbuild.diff

Review of attachment 8375672 [details] [diff] [review]:
-----------------------------------------------------------------

Think I need a win check too, will include in next patch
Attachment #8375672 - Flags: review?(ehsan)
Attachment #8375672 - Attachment is obsolete: true
Attachment #8375678 - Flags: review?(ehsan)
Comment on attachment 8375678 [details] [diff] [review]
bug972459_sandboxbuild.diff

Review of attachment 8375678 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/app/moz.build
@@ +22,5 @@
>      '/xpcom/base',
>  ]
> +
> +if CONFIG['MOZ_CONTENT_SANDBOX'] and CONFIG['OS_ARCH'] == 'WINNT':
> +    LOCAL_INCLUDES += [

Can you please add a comment saying why these are needed, even though these directories do not have any headers inside them?  That should hopefully help the next person not get confused and mess up with these again!
Attachment #8375678 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/b18f669df651
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.