Closed
Bug 972463
Opened 11 years ago
Closed 11 years ago
[Clock] jslintify all the things
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
1.4 S1 (14feb)
People
(Reporter: mcav, Assigned: mcav)
Details
(Whiteboard: [p=3])
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → m
Status: NEW → ASSIGNED
Target Milestone: --- → 1.4 S1 (14feb)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8375634 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16252
These changes are all just fixes for the complainin' that JSHint does. Depending on when this lands it may need other fixes (if anything else landed in the meantime), but I'll take an r+ as conditional on all the tests passing on travis.
Attachment #8375634 -
Flags: review?(mmedeiros)
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [p=3]
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8375634 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16252
I added a few comments, basically to try to reduce duplication across files - define common globals to a shared `.jshintrc` file and leave the `/* global */` comments only for file-specific globals. But TBH it looks good to me anyway.
Attachment #8375634 -
Flags: review?(mmedeiros) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Landed:
https://github.com/mozilla-b2g/gaia/commit/4830eedd1bde5de11f6a4914914a811786855955
I updated .jshintrc to remove the duplication, as Miller suggested, good call! Now we have all the lints!
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•11 years ago
|
||
Marking as VERIFIED per :edchen's request. Can confirm, all the things are jshintified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•