972479 - [webvtt] TextTracks added to a TextTrackList through an HTMLTrackElement should dispatch 'onaddtrack' event

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Rick Eyre (:reyre)]

We're dispatching 'onaddtrack' events for TextTracks added to a TextTrackList via the TextTrackList::AddTrack function, but not when a TextTrack gets added via an HTMLTrackElement.

Comment 1

[Rick Eyre (:reyre)]

Attachment: v1: TextTracks added to a TextTrackList through an HTMLTrackElement should dispatch 'onaddtrack' event r=rillian

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8375662 [details] [diff] [review]
v1: TextTracks added to a TextTrackList through an HTMLTrackElement should dispatch 'onaddtrack' event r=rillian

Review of attachment 8375662 [details] [diff] [review]:
-----------------------------------------------------------------

Would be good to document in the body of the commit message that this worked because of which AddTextTrack method HTMLTrackElement calls.

Comment 3

[Rick Eyre (:reyre)]

Attachment: v2: TextTracks added to a TextTrackList through an HTMLTrackElement should dispatch 'onaddtrack' event r=rillian

Update the commit message as per Ralph's request.

Comment 4

[Rick Eyre (:reyre)]

Thanks for review Ralph.

Try: https://tbpl.mozilla.org/?tree=Try&rev=06be8ca840b7

Comment 5

[Rick Eyre (:reyre)]

Looks good.

Comment 6

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f73e612c9641

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f73e612c9641