972497 - On locked call screen arrows are not the same

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[zlati.pehlivanov]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140127194636

Steps to reproduce:

Receive a call in a locked screen state


Actual results:

the interface appeared for choosing to pickup or hang the call. the right icon is smaller then the left one.


Expected results:

the icons should be the same

Comment 1

[zlati.pehlivanov]

bug appears in 1.4 nightly build 
nightly-images-peak-master-2014-02-13.Gecko-90b607e.Gaia-7800373

Comment 2

[zlati.pehlivanov]

Attachment: 2014-02-13-21-10-28.png

Comment 3

[Anthony Ricaud (:rik)]

Are you still seeing this? I can't reproduce on a Peak.

Comment 4

[zlati.pehlivanov]

Yes, even in 1.5, the build number I have installed is 20140329064833

Comment 5

[zlati.pehlivanov]

You should be in a locked state

Comment 6

[Anthony Ricaud (:rik)]

Ah right, I'm seeing it. Greg: this looks like an issue on all high density screens, could you look into it?

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

It's a weird case that two arrows are not the same.
I'll check if the ordinary LockScreen has the same issue first (because the slider is using the same code).

Comment 8

[zlati.pehlivanov]

the ordinary LockScreen is ok

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Hmm...I've confirmed this on Nexus 4. The most strange thing is the images, code and style should be the same in these two sliders.

Need info Steve because I need his opinion to debug with the incoming LockScreen.

Comment 10

[Anthony Ricaud (:rik)]

FYI, now that the call screen is a standalone app, you can inspect it with the app manager. If you remove the code that closes the call screen when an entering call is dropped, you can keep it open for as long as you need.

Comment 11

[Steve Chung [:steveck]]

https://github.com/mozilla-b2g/gaia/tree/master/apps/callscreen/style/images
It looks like we missed the 1.5X rarrow.png

Comment 12

[Anthony Ricaud (:rik)]

And 2x…

We're reproducing this on a Peak but from comment 11, this will reproduce on any hi-res device. Asking to block 1.3 if we ship on hi-res devices.

Stephany: Who should have those assets?

Comment 13

[Greg Weng [:snowmantw][:gweng][:λ]]

It's a missing PNG file that already in the System app, but not copied to the dialer app. This was identified last week.

I would make a patch and sent later.

Comment 14

[Jason Smith [:jsmith]]

Definitely not a blocker - this a visual glitch fallout, which isn't critical enough to block 1.3 at this point. 1.3 blockers have to be cert issues at this point.

Comment 15

[Anthony Ricaud (:rik)]

Given how simple and non risky the patch will be, I think we should ask approval for all branches.

Comment 16

[Anthony Ricaud (:rik)]

Actually, it's not the case. https://github.com/mozilla-b2g/gaia/tree/bd16a10702e801b717f8848ee7ccc79f781c8f79/apps/system/style/lockscreen/images has no 2x version of those icons…

Comment 17

[Stephany Wilkes]

Flagging Patryk to flag whomever may be needed on visual assets.

Comment 18

[Patryk Adamczyk [:patryk] UX]

Amy should be able to provide these.

Comment 19

[Amy Lee [:amylee] UX]

Attachment: arrows_x1.5_x2.zip

Hi, 

I've provided pngs of the arrows @1.5 and @2 scale. Let me know if you need anything else!

Comment 20

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch

I have copied the image files into the directory and tested the results with a Nexus 5. @gweng, please review, thanks

Comment 21

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8420810 [details] [review]
Patch

Verified with real device, so here is the r+.

Comment 22

[John Lu [:mnjul][Please NI or I'll miss]]

The patch has landed into master: https://github.com/mozilla-b2g/gaia/commit/18871c73e8cf0e09b4ce5d3fad80809cac7fcb88 with the help of @gweng.

Comment 23

[Anthony Ricaud (:rik)]

Comment on attachment 8420810 [details] [review]
Patch

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New lockscreen design
[User impact] if declined: Weird look when receiving phone calls on hidpi phones, see attachment 8375684 [details].
[Testing completed]: Tested by patch author and reviewer in comment 20 and 21.
[Risk to taking this patch] (and alternatives if risky): Just new images that were missing.
[String changes made]: None

Comment 24

[Preeti Raghunath(:Preeti)]

Comment on attachment 8420810 [details] [review]
Patch

Taking in release 1.4 for inconsistent UI.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/8806eebe8f1555b1f924166f921ab831a5e3560c

Comment 26

[zlati.pehlivanov]

what about v1.5 can this fix be included in the next nightly build for 1.5

Comment 27

[Anthony Ricaud (:rik)]

1.5 is 2.0 (and master at the moment) so it was fixed 3 days ago with comment 22.