XBL Default Content Bug in LocateInstance

RESOLVED FIXED in mozilla0.9.7

Status

()

Core
XBL
RESOLVED FIXED
17 years ago
16 years ago

People

(Reporter: jag (Peter Annema), Assigned: Joe Hewitt (gone))

Tracking

Trunk
mozilla0.9.7
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [xbl 1.0])

Attachments

(1 attachment)

1.18 KB, patch
jag (Peter Annema)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

17 years ago
In bindings/titledbox.xml, put:

  <binding id="caption"
extends="chrome://global/content/bindings/general.xml#basetext">
    <content>
      <xul:hbox inherits="orient,align,pack,dir" class="box-inherit
button-text-box" align="center" pack="center"> <!-- should not be needed -->
      <children>
      <xul:image class="caption-icon" inherits="src=image"/>
      <xul:label class="caption-text" flex="1"
                 inherits="default,value=label,crop,accesskey"/>
      </children>
      </xul:hbox> <!-- should not be needed -->
    </content>
  </binding>
add proper binding in xul.css, add caption to groupbox's first children
includes, and add caption to your favorite skin's proper css file. Oh, and
change a few labels inside groupboxes to captions :-)

Updated

17 years ago
Status: NEW → ASSIGNED
Whiteboard: [xbl 1.0]
Target Milestone: --- → mozilla0.9.5

Updated

17 years ago
Target Milestone: mozilla0.9.5 → mozilla0.9.6
(Assignee)

Updated

17 years ago
Blocks: 70858

Updated

16 years ago
Summary: Bug in LocateInstance → XBL Default Content Bug in LocateInstance
Target Milestone: mozilla0.9.6 → mozilla0.9.7
(Assignee)

Comment 1

16 years ago
taking
Assignee: hyatt → hewitt
Status: ASSIGNED → NEW
(Assignee)

Comment 2

16 years ago
Created attachment 59940 [details] [diff] [review]
patch

woohoo!
(Reporter)

Comment 3

16 years ago
Comment on attachment 59940 [details] [diff] [review]
patch

r=jag
Attachment #59940 - Flags: review+
(Assignee)

Comment 4

16 years ago
fixed
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.