972613 - In-memory sync rate limiting

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Richard Newman [:rnewman]]

We're back to our old friend Android syncing us twice in a row.

02-13 15:02:33.342 I/FxAccounts( 9595): fennec_rnewman :: FxAccountSchedulePolicy :: Scheduling periodic sync for 28800.
02-13 15:02:33.382 I/FxAccounts( 9595): fennec_rnewman :: FxAccountSyncAdapter :: Sync succeeded.
02-13 15:02:33.382 E/FxAccounts( 9595): fennec_rnewman :: FxAccountSyncAdapter :: Syncing done.
02-13 15:02:33.452 I/FxAccounts( 9595): fennec_rnewman :: FxAccountSyncAdapter :: Syncing FxAccount account named like [e-mail] for authority org.mozilla.fennec_rnewman.db.browser with instance org.mozilla.gecko.fxa.sync.FxAccountSyncAdapter@21651f10.
02-13 15:02:33.452 I/FxAccounts( 9595): fennec_rnewman :: AndroidFxAccount :: $$FxA PII$$: email: [e-mail]


We should keep a flag in the SyncAdapter instance to detect this and skip over it.

And maybe we should also be keeping the AndroidFxAccount instance around...

Comment 1

[Nick Alexander :nalexander [he/him]]

I see this on pretty much every sync; I've always assumed this is because the Fennec CPs are not notification clean.

Comment 2

[Richard Newman [:rnewman]]

Yup, or another sync request arrived while we were syncing, and Android queues them?

Regardless, especially as we start to listen to multiple CRs, we should take the very cheap step of recognizing when we just finished syncing.

Comment 3

[Richard Newman [:rnewman]]

Attachment: Patch. v1

This is trivial, so I'm just landing it.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/b72687a8ff19

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b72687a8ff19

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8376015 [details] [diff] [review]
Patch. v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  FxA Sync.

User impact if declined: 
Testing completed (on m-c, etc.): 
  m-c and QAed.

Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch:

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7ee83a05f105