Closed
Bug 972615
Opened 11 years ago
Closed 11 years ago
add esr24 relbranches to gecko-dev
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
Attachments
(1 file)
674 bytes,
patch
|
hwine
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
For Tor.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8375858 -
Flags: review?(hwine)
Comment 2•11 years ago
|
||
Comment on attachment 8375858 [details] [diff] [review]
esr24
Review of attachment 8375858 [details] [diff] [review]:
-----------------------------------------------------------------
One nit - r+ whether you make that change or not.
::: configs/vcs_sync/beagle.py
@@ +388,5 @@
> "branches": {
> "default": "esr24",
> },
> + "branch_regexes": {
> + "^GECKO[0-9]+esr_[0-9]+_RELBRANCH",
Since we anchor at the front of the expression (^), shouldn't we anchor at the end as well? ($)
Attachment #8375858 -
Flags: review?(hwine) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8375858 [details] [diff] [review]
esr24
http://hg.mozilla.org/build/mozharness/rev/5ec7c421defd
Attachment #8375858 -
Flags: checked-in+
Assignee | ||
Comment 4•11 years ago
|
||
Seeing the ESR 24 relbranches in gecko-dev, e.g.:
https://github.com/mozilla/gecko-dev/tree/GECKO2430esr_2014013111_RELBRANCH
Mike: a) sorry for the delay, and b) sorry for the imperfect fix.
In the not-too-distant future, we should have mapper available to the public, which will allow people to determine git shas from hg shas and vice versa (bug 847640). Longer term we'd like to move away from moving hg tags in our release process, which will allow for converting them without those issues.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•11 years ago
|
||
Oh, also followup fix: http://hg.mozilla.org/build/mozharness/rev/452f8b450cb0
Updated•8 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•