972651 - Failing video marionette test: video_list_test.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Kevin Grandon :kgrandon]

1) video list "before each" hook:

JavaScriptError: (17) TypeError: noMoreWorkCallback is not a function

Remote Stack:

@app://video.gaiamobile.org/js/metadata.js, line 120

at Error.MarionetteError (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/error.js:67:13)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:474:19)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:508:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:94:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:455:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:501:19)

at Object._executeScript (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1448:19)

at Object.executeAsyncScript (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1229:19)

at Object.Client.waitForSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:674:14)

at Object.Client.waitFor (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:648:60)

at Object.MarionetteHelper.waitForElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-helper/index.js:131:12)

at Object.Video.launch (/home/travis/build/mozilla-b2g/gaia/apps/video/test/marionette/lib/video.js:194:24)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/video/test/marionette/video_list_test.js:41:9)

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:211:32)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:257:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:269:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:197:9

at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:370:18)

at process._tickCallback (node.js:415:13)

Comment 1

[Kevin Grandon :kgrandon]

Punam - this test recently decided to have intermittent failures on us. Any chance you could take a look?

Comment 2

[Punam Dahiya [:pdahiya]]

Looks like flatfish changes in video app Bug 903920 could be the reason. I will assign it to myself and look into it. Thanks

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: PR with fix of intermittent video_list_test failure

Hi John
Can you please review this patch, where we are explicitly checking as noMoreWorkCallback before calling it? I have run marionette test multiple times on this fix and video tests seems to fair well in all the jobs

https://travis-ci.org/mozilla-b2g/gaia/builds/18919462

Thanks
Punam

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8376655 [details] [review]
PR with fix of intermittent video_list_test failure

Punam,

Thanks for this patch. That's my fault from the tablet patch. I forget to check it. Thanks.

Comment 5

[Punam Dahiya [:pdahiya]]

Thanks John for the review. A fix for this issue is landed as part of bug 960901. 

https://github.com/mozilla-b2g/gaia/commit/56ddd220f786916d596ea60ee170af0678d19838#diff-04cef62435c1e1c73bf49157c6868956R121

Kevin, I am marking the bug resolved. Please feel free to reopen the bug if you still see this issue. Thanks

Comment 6

[Kevin Grandon :kgrandon]

That other fix is being backed out shortly, and we should take this one instead (safer and doesn't break if undefined).

Reopening for now and will land as appropriate.

Comment 7

[Kevin Grandon :kgrandon]

Leaving the other bug landed, and submitting a follow-up. Thanks for the patch!