972702 - Cert viewer dialog isn't usefully resizable (i.e. making it taller just adds blank space at bottom of dialog)

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
1. View the cert details for e.g. this bug page (served over HTTPS), by clicking on the left side of the URL bar, then "More information", then "View Certificate"

2. Click "Details" on the dialog that pops up, to see the Certificate Fields

3. Resize the dialog to increase its height.

ACTUAL RESULTS: It grows, but its content areas don't get any larger. There's just blank space at the bottom.

EXPECTED RESULTS: The content areas (or at least the overflowing "Certificate Fields" area) should grow to display more, as the dialog grows.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of resized (tall) dialog

Comment 2

[Daniel Holbert [:dholbert]]

I'm using current Nightly 30.0a1 (2014-02-13) on 64-bit Linux
Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0
...though I'll bet this bug has probably existed since forever.

Comment 3

[:Cykesiopka]

Attachment: bug972702_v1.patch

For the "certDumpVal" textbox, rows="8" doesn't force a min height.
I use 11em as it is almost equivalent on my Ubuntu VM and Windows machine.

Comment 4

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8428206 [details] [diff] [review]
bug972702_v1.patch

Review of attachment 8428206 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks for working on this!
Feel free to remove the nearby trailing spaces in certDump.xul as well (or in a separate whitespace-only patch if you like).

Comment 5

[:Cykesiopka]

Attachment: bug972702_v2.patch

(In reply to David Keeler (:keeler) [use needinfo?] from comment #4)
> Looks good to me. Thanks for working on this!
> Feel free to remove the nearby trailing spaces in certDump.xul as well (or
> in a separate whitespace-only patch if you like).

No problem.
I removed the trailing whitespace in both files in this patch as well.

https://tbpl.mozilla.org/?tree=Try&rev=9a965ebb3fc1 - all green!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f69a3a58343

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f69a3a58343