Closed Bug 972713 Opened 6 years ago Closed 5 years ago

Inactive layer construction can behave in strange ways

Categories

(Core :: Layout, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(2 files, 1 obsolete file)

A few patches coming up.
Attachment #8376030 - Flags: review?(matt.woodrow) → review+
Attachment #8376032 - Flags: review?(matt.woodrow) → review+
The first hunk of patch #1 causes regressions. The problem is that for, say, an inactive transform display item or an SVG-transformed display item, GetAnimatedGeometryRootFor(i, aBuilder) returns the item's own frame as the geometry root --- because we don't let the search go up beyond i's ReferenceFrame(), which is its own frame. OTOH GetAnimatedGeometryRootFor(i->Frame()) would search all the way up to an actual animated geometry root. So we think the item is an animated geometry root and RequiredLayerStateForChildrenInternal returns LAYER_ACTIVE, which is wrong.
Attached patch Part 1 v2Splinter Review
Attachment #8376030 - Attachment is obsolete: true
Attachment #8377328 - Flags: review?(matt.woodrow)
Attachment #8377328 - Flags: review?(matt.woodrow) → review+
So this made bug 791480 start happening 100% of the time on the Win8 reftest-noaccel.

I landed 
https://hg.mozilla.org/integration/mozilla-inbound/rev/94e20568f4e8
before realizing that this was a new 100%-of-the-time failure rather than an intermittent whose annotation needed updating.
https://hg.mozilla.org/mozilla-central/rev/b5486b9ed88c
https://hg.mozilla.org/mozilla-central/rev/7829e535cdd7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Per comment 7, this shouldn't have been merged to m-c.
Status: RESOLVED → REOPENED
Flags: needinfo?(cbook)
Resolution: FIXED → ---
Target Milestone: mozilla30 → ---
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #9)
> Per comment 7, this shouldn't have been merged to m-c.

grr sorry yeah my fault will merge the backout cset to m-c when its ready
Flags: needinfo?(cbook)
Also, shouldn't dbaron's change in comment 6 be backed out? Doesn't look like it was.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #11)
> Also, shouldn't dbaron's change in comment 6 be backed out? Doesn't look
> like it was.

setting needinfo for dbaron so that this don't get lost
Flags: needinfo?(dbaron)
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #7)
> Backed out:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/148794d81e95

also landed on central as https://hg.mozilla.org/mozilla-central/rev/148794d81e95 (sorry again, my fault)
RyanVM backed it out.
Flags: needinfo?(dbaron)
I can't reproduce this on my Windows laptop, having tried various configurations.

I'll try chaos mode to see if that helps.
Status: REOPENED → NEW
https://hg.mozilla.org/mozilla-central/rev/c6a7a027c126
https://hg.mozilla.org/mozilla-central/rev/93265ade3bc9
Status: NEW → RESOLVED
Closed: 6 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Depends on: 1000167
You need to log in before you can comment on or make changes to this bug.