Closed Bug 972732 Opened 6 years ago Closed 6 years ago

Move BluetoothServiceBluedroid.{cpp,h} out from gonk folder and BluetoothDBusService.{cpp,h} from linux folder

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ben.tian, Assigned: ben.tian)

References

Details

Attachments

(2 files, 2 obsolete files)

Move dom/bluetooth/bluedroid/gonk/BluetoothServiceBluedroid.{cpp,h}
to dom/bluetooth/bluedroid/BluetoothServiceBluedroid.{cpp,h}
Assignee: nobody → btian
Attachment #8376058 - Flags: review?(echou)
With bug 969314 being fixed, should we do something similar for BlueZ?
Flags: needinfo?
Sure. We should move them out since only 1 messaging protocol (dbus) is supported right now. I'll prepare a new patch.
Flags: needinfo?
(In reply to Ben Tian [:btian] from comment #3)
> Sure. We should move them out since only 1 messaging protocol (dbus) is
> supported right now. I'll prepare a new patch.

Please make it depend on bug 972253. I don't want to redo these fixes because the file paths changed. ;)
Depends on: 972253
Summary: Move BluetoothServiceBluedroid.{cpp,h} out from gonk folder → Move BluetoothServiceBluedroid.{cpp,h} out from gonk folder and BluetoothDBusService.{cpp,h} from linux folder
Also revise an OPP minor error. Will mark r? once bug 972253 is landed.
Attachment #8376058 - Attachment is obsolete: true
Attachment #8376058 - Flags: review?(echou)
Comment on attachment 8376101 [details] [diff] [review]
Patch 1 (v2): Move files out from bluez/linux and bluedroid/gonk

Let's mark this for a review.
Attachment #8376101 - Flags: review?(echou)
Comment on attachment 8376101 [details] [diff] [review]
Patch 1 (v2): Move files out from bluez/linux and bluedroid/gonk

Review of attachment 8376101 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for reminding, Thomas. :)

::: dom/bluetooth/bluedroid/BluetoothOppManager.cpp
@@ +1463,5 @@
>    if (aSocket != mSocket) {
>      // Do nothing when a listening server socket is closed.
>      return;
>    }
> +  BT_LOGR("[%s]", (mIsServer) ? "server" : "client");

Good catch. ;)
Attachment #8376101 - Flags: review?(echou) → review+
Attachment #8381105 - Flags: review?(echou) → review+
Blocks: 939672
You need to log in before you can comment on or make changes to this bug.