Closed
Bug 972732
Opened 10 years ago
Closed 10 years ago
Move BluetoothServiceBluedroid.{cpp,h} out from gonk folder and BluetoothDBusService.{cpp,h} from linux folder
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ben.tian, Assigned: ben.tian)
References
Details
Attachments
(2 files, 2 obsolete files)
4.17 KB,
patch
|
Details | Diff | Splinter Review | |
915 bytes,
patch
|
echou
:
review+
|
Details | Diff | Splinter Review |
Move dom/bluetooth/bluedroid/gonk/BluetoothServiceBluedroid.{cpp,h} to dom/bluetooth/bluedroid/BluetoothServiceBluedroid.{cpp,h}
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → btian
Attachment #8376058 -
Flags: review?(echou)
Comment 2•10 years ago
|
||
With bug 969314 being fixed, should we do something similar for BlueZ?
Flags: needinfo?
Assignee | ||
Comment 3•10 years ago
|
||
Sure. We should move them out since only 1 messaging protocol (dbus) is supported right now. I'll prepare a new patch.
Flags: needinfo?
Comment 4•10 years ago
|
||
(In reply to Ben Tian [:btian] from comment #3) > Sure. We should move them out since only 1 messaging protocol (dbus) is > supported right now. I'll prepare a new patch. Please make it depend on bug 972253. I don't want to redo these fixes because the file paths changed. ;)
Assignee | ||
Updated•10 years ago
|
Summary: Move BluetoothServiceBluedroid.{cpp,h} out from gonk folder → Move BluetoothServiceBluedroid.{cpp,h} out from gonk folder and BluetoothDBusService.{cpp,h} from linux folder
Assignee | ||
Comment 5•10 years ago
|
||
Also revise an OPP minor error. Will mark r? once bug 972253 is landed.
Attachment #8376058 -
Attachment is obsolete: true
Attachment #8376058 -
Flags: review?(echou)
Comment 6•10 years ago
|
||
Comment on attachment 8376101 [details] [diff] [review] Patch 1 (v2): Move files out from bluez/linux and bluedroid/gonk Let's mark this for a review.
Attachment #8376101 -
Flags: review?(echou)
Comment 7•10 years ago
|
||
Comment on attachment 8376101 [details] [diff] [review] Patch 1 (v2): Move files out from bluez/linux and bluedroid/gonk Review of attachment 8376101 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for reminding, Thomas. :) ::: dom/bluetooth/bluedroid/BluetoothOppManager.cpp @@ +1463,5 @@ > if (aSocket != mSocket) { > // Do nothing when a listening server socket is closed. > return; > } > + BT_LOGR("[%s]", (mIsServer) ? "server" : "client"); Good catch. ;)
Attachment #8376101 -
Flags: review?(echou) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8376101 -
Attachment is obsolete: true
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8381105 -
Flags: review?(echou)
Updated•10 years ago
|
Attachment #8381105 -
Flags: review?(echou) → review+
Assignee | ||
Comment 10•10 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=32d5681d4a79
Assignee | ||
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/edccc6d303af https://hg.mozilla.org/integration/b2g-inbound/rev/24881928d5da
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/edccc6d303af https://hg.mozilla.org/mozilla-central/rev/24881928d5da
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•