972753 - Test decoding of OCSP response that contains multiple certificates

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P4)

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

In particular, we should make sure we're unwrapping the sequences appropriately when there are multiple certificates. Look for this code:

      // Unwrap the SEQUENCE that contains the certificate, which is itself a
      // SEQUENCE.

Comment 3

[Dana Keeler (she/her) [:keeler]]

Attachment: patch

This actually tests delegated responses as well as having multiple certificates in the OCSP response.

Comment 4

[Camilo Viecco (:cviecco)]

Comment on attachment 8398666 [details] [diff] [review]
patch

Review of attachment 8398666 [details] [diff] [review]:
-----------------------------------------------------------------

just minor nits for readability

::: security/manager/ssl/tests/unit/tlsserver/generate_certs.sh
@@ +146,5 @@
>  
>  make_EE inadequatekeyusage 'CN=Inadequate Key Usage Test End-entity' testCA "inadequatekeyusage.example.com" "--keyUsage crlSigning"
>  make_EE selfsigned-inadequateEKU 'CN=Self-signed Inadequate EKU Test End-entity' unused "selfsigned-inadequateEKU.example.com" "--keyUsage keyEncipherment,dataEncipherment --extKeyUsage serverAuth" "-x"
>  
> +make_EE delegatedSigner 'CN=Test Delegated Responder' testCA "invalid.invalid.invalid" "--extKeyUsage ocspResponder"

no-subjectaltname.invalid (? readabilityy)

::: security/pkix/test/lib/pkixtestutil.h
@@ +35,5 @@
>    pkix::ScopedCERTCertificate issuerCert; // The issuer of the subject
>    pkix::ScopedCERTCertificate signerCert; // This cert signs the response
>    uint8_t responseStatus; // See the OCSPResponseStatus enum in rfc 6960
>    bool skipResponseBytes; // If true, don't include responseBytes
> +  pkix::ScopedCERTCertificate includedCertificates[4];

make the 4 a const int or #define

Comment 5

[Dana Keeler (she/her) [:keeler]]

Attachment: patch v2

Comment 6

[Dana Keeler (she/her) [:keeler]]

Thanks, Camilo.
https://tbpl.mozilla.org/?tree=Try&rev=6337d1fde760

Comment 7

[Dana Keeler (she/her) [:keeler]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b394e883b806

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b394e883b806