972756 - [B2G][Dailer_DTMF][Baoqing Wu]The other UE will receiver a different DTMF due to the DTMF in FFOS is send when the key is up

Status: RESOLVED DUPLICATE of bug 922569

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[lecky]

Test step:
1.The FFOS UE as A, the other android UE as B. A make a call to B.
2.Press down one key continuantly in the A.
3.Press up the key in the A.

expect result:
In the 2th step, B should receive a tone continuantly.
In the 3th step, the tone is stop in the B.

actual result:
In the 2th step, B don't receive anything.
In the 3th step, B receive a short tone.

Analysis:
In the dialer.js, 
The start DTMF and end DTMF are send when the key is press up.

But from the 3GPP TS 23.014, the start DTMF should be send when the key is pressed down, and the end DTMF should be send when the key is pressed up. Please check the doc and attachment.

Comment 1

[lecky]

Attachment: Flow.png

Comment 2

[lecky]

BTW the version of my code is V1.1HD, and i'm sorry for wrong type, the name of file is keypad.js not dialer.js.


I have checked the V1.0 code, and it is different from V1.1HD.

In the V1.0 Code,
The Start DTMF is send when the key is press down, and the end DTMF is send when the key is press up or leave.

Who could tell me why change this?

Comment 3

[Jason Smith [:jsmith]]

Not a regression, so not blocking.

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

IIRC this behavior changed twice. In 1.0.x long presses used to be sent immediately, then in 1.1.x they were sent only after the used stopped pressing a button. This was later fixed by going back to the original behavior in bug 922569 which should have been uplifted to 1.3. Should we dupe against that one maybe?