972879 - crash in java.lang.NoSuchMethodError: android.widget.RelativeLayout.setSystemUiVisibility at org.mozilla.gecko.GeckoApp$32.run(GeckoApp.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-83d664a8-3591-4491-917b-1db092140213.
=============================================================

java.lang.NoSuchMethodError: android.widget.RelativeLayout.setSystemUiVisibility
	at org.mozilla.gecko.GeckoApp$32.run(GeckoApp.java:2802)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3691)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:912)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:670)
	at dalvik.system.NativeStart.main(Native Method)

Specific to Android 2.3; seems to affect the Kindle, original Desire and an Ace 2

Comment 1

[Aaron Train [:aaronmt]]

http://developer.android.com/reference/android/view/View.html#SYSTEM_UI_FLAG_VISIBLE

Was added in API 14

http://mxr.mozilla.org/mozilla-aurora/source/mobile/android/base/GeckoApp.java#2802

Needs a check.

Comment 2

[Lucas Rocha (:lucasr)]

Josh, seems like a regression from bug 960159. Could you have a look?

Comment 3

[Josh Dover [:jdover]]

Attachment: Only dim system UI on SDK >= 14

Added check to make sure we don't call this on SDK < 14

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8377652 [details] [diff] [review]
Only dim system UI on SDK >= 14

Review of attachment 8377652 [details] [diff] [review]:
-----------------------------------------------------------------

Yep. Is this Aurora too? Make sure you request uplift if it is.

Comment 5

[Josh Dover [:jdover]]

Yes, how do I do that?

Comment 6

[Josh Dover [:jdover]]

Comment on attachment 8377652 [details] [diff] [review]
Only dim system UI on SDK >= 14

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch:

Comment 7

[Josh Dover [:jdover]]

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 160159
User impact if declined: Crashes in Reader Mode on anything below ICS due to unsupported system flag
Testing completed (on m-c, etc.): n/a
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/43e07016a5bb

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/43e07016a5bb

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c64d29708390