972955 - Non-existant S3 key in signer is a 500

Status: RESOLVED FIXED

(Marketplace Graveyard :: Integration, defect, P2)

Description

[Kumar McMillan [:kumar]]

A non-existant key caused a 500 but that should be a 400 with an informative error

http://sentry.shared.us-east-1.stage.mozaws.net/sentry-internal/apk-signer-stage/group/4/

NoSuchKey

Key TestApp-release-unsigned.apk does not exist in <Bucket: net.mozaws.stage.apk.public>

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 114, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "django/views/generic/base.py", line 69, in view
    return self.dispatch(request, *args, **kwargs)
  File "django/views/decorators/csrf.py", line 57, in wrapped_view
    return view_func(*args, **kwargs)
  File "rest_framework/views.py", line 399, in dispatch
    response = self.handle_exception(exc)
  File "rest_framework/views.py", line 396, in dispatch
    response = handler(request, *args, **kwargs)
  File "apk_signer/sign/views.py", line 40, in post
    with storage.get_apk(src) as fp:
  File "apk_signer/storage/__init__.py", line 39, in get_apk
    prefix='tmp_unsigned_')
  File "apk_signer/storage/__init__.py", line 53, in get
    .format(path=key_path, bkt=bkt))

Comment 1

[Kumar McMillan [:kumar]]

https://github.com/mozilla/apk-signer/commit/9a72228f3fa238cdc153215d69ffced87be5642c