973048 - remove nsNSSCleaner

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

The "Cleaner" paradigm is inferior to our already-supported scoped pointer types.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

My upcoming patch for bug 915930 removes all uses of CERTVerifyLog from PSM. I suggest we work on other stuff until that happens. If we end up not removing the use of CERTVerifyLog then let's revisit this.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: patch

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Great - thanks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d78ba0011051

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Whoops - broke non-unified builds. This should fix it: https://hg.mozilla.org/integration/mozilla-inbound/rev/9b0dee116f29

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d78ba0011051
https://hg.mozilla.org/mozilla-central/rev/9b0dee116f29
https://hg.mozilla.org/mozilla-central/rev/ff7846e93eaf