973085 - Do initialization in onCreate instead of onWindowFocusChanged

Status: RESOLVED DUPLICATE of bug 1085591

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

onWindowFocusChanged isn't designed to be used for application initialization. IIRC, we use it because it happens later in startup and allows us to show an empty window more quickly; however, the docs say that it is "managed independently of activity lifecycles" and apps "should not rely on any particular order between the callbacks here and those in the other lifecycle methods" (http://developer.android.com/reference/android/app/Activity.html#onWindowFocusChanged%28boolean%29).

We should simply do initialization in onCreate(): onCreate is fired exactly once, and it's the intended hook for initialization.

Comment 1

[Geoff Brown [:gbrown]]

I tried simply moving the initialize() call, but that did not work: https://tbpl.mozilla.org/?tree=Try&rev=7c81292ec94a

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The patch bug 966788 comment 138 landed an increased wait time for Gecko:Ready - we should probably revert that back once this bug is solved.

Comment 3

[Richard Newman [:rnewman]]

Forward-duping.