973111 - Move NativeWindow.context menus to a jsm

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

It would be nice for everyone, if the NativeWindow apis could be used without needing a window object. As a start (along with other refactoring work for quick share in context menus), I want to move NativeWindow.contextmenus to a jsm. We can provide a shim in browser.js so that everything there continues to work as normal.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch 1/2 - Move to a jsm

This is a straight move. Fennec won't work with this. We'll have to fold it with patch 2 when landing.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch 2/2 - Make it work

This fixes things up so that context menus continue to work like normal.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8376597 [details] [diff] [review]
Patch 2/2 - Make it work

I want to take a slightly different approach to this refactor. I also don't want this to block any Quick Share work.

Let's regroup after the QuickShare work is done

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.