973171 - Don't use italic text in CJKT pages

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Italic does not work for Chinese glyphs, we need to reset all uses of italic or oblique for zh-* locales on the site.

Comment 1

[Kohei Yoshino [:kohei]]

Also in Japanese (ja)

Comment 2

[Kohei Yoshino [:kohei]]

And maybe Korean (ko)

Comment 3

[Kohei Yoshino [:kohei]]

Attachment: pull request

Comment 4

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

wouldn's it make sense to force that for all enlements in base templates? Like:


html[lang='ja'] *,
html[lang='ko'] *,
html[lang|='zh'] * {
    font-style: normal !important;
}

this way we can make sure for future pages using the base template are unaffected and we don't need to add rules to files for specific pages like partners?

Comment 5

[Kohei Yoshino [:kohei]]

Oh, that makes sense.

I'm writing another PR:
https://github.com/kyoshino/bedrock/compare/locale-fonts

Comment 6

[Kohei Yoshino [:kohei]]

Added those locale-specific rules in a PR for Bug 973396:
https://github.com/mozilla/bedrock/pull/1706

Comment 7

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Attachment: github pull request

I see that you closed your PR and that the PR in Bug 973396 isn't ready to be merged. Since we need this fix for  MWC pages going live tomorrow, I am requesting my initial patch to be merged in.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/2ed21370a30dc4431cdb1ccda21be4c96043bb81
Bug 973171: never use italic font styles for Chineses/Japanese/Korean

https://github.com/mozilla/bedrock/commit/ddd1e0149769b3c0989347b057e0361b0a4d129f
Merge pull request #1721 from pascalchevrel/bug-973171-CJKT-locales-no-italic-font

Bug 973171: never use italic font styles for Chineses/Japanese/Korean