973187 - typo in nsStyleGradient::HasCalc()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Maks Naumov]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140212131424

Steps to reproduce:

layout\style\nsStyleStruct.cpp 1545

 return mBgPosX.IsCalcUnit() || mBgPosY.IsCalcUnit() || mAngle.IsCalcUnit() ||
         mRadiusX.IsCalcUnit() || mRadiusX.IsCalcUnit();

I think should be:
 return mBgPosX.IsCalcUnit() || mBgPosY.IsCalcUnit() || mAngle.IsCalcUnit() ||
         mRadiusX.IsCalcUnit() || mRadiusY.IsCalcUnit();

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(In reply to Maks Naumov from comment #0)
> layout\style\nsStyleStruct.cpp 1545
> 
>  return mBgPosX.IsCalcUnit() || mBgPosY.IsCalcUnit() || mAngle.IsCalcUnit()
> ||
>          mRadiusX.IsCalcUnit() || mRadiusX.IsCalcUnit();
> 
> I think should be:
>  return mBgPosX.IsCalcUnit() || mBgPosY.IsCalcUnit() || mAngle.IsCalcUnit()
> ||
>          mRadiusX.IsCalcUnit() || mRadiusY.IsCalcUnit();

Well, that's effectively submitting a patch, even though it's not in patch format.  So r=dbaron, and I'll commit this for you later.  Thanks.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5d74728a7ab

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c5d74728a7ab