973308 - "Assertion failure: !isinf(t_min) && !isinf(t_max) (The first call to UpdateLinearParametersToIncludePoint should have made t_min and t_max non-infinite.)"

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jesse Ruderman]

Attachment: stack

I tried to reproduce bug 928168 comment 58 in a debug build. I hit this instead:

Assertion failure: !isinf(t_min) && !isinf(t_max) (The first call to UpdateLinearParametersToIncludePoint should have made t_min and t_max non-infinite.), at /Users/jruderman/trees/mozilla-central/gfx/2d/DrawTargetCG.cpp:476

I wasn't able to reproduce by loading the same Twitter pages, though.

Interestingly, bug 928168 comment 68 also suggests a link between this assertion and the crash in bug 928168.

Comment 1

[Markus Stange [:mstange]]

Attachment: v1

CG helpfully sets the origin of empty clip bounds to -inf, -inf. This messes up our calculations.

My attempts to create a testcase for this were unsuccessful.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

> My attempts to create a testcase for this were unsuccessful.

The "new" crashes at bug 928168 now have STR.  See bug 928168 comment #70 and bug 928168 comment #71.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

I've opened bug 973971 for the crashes associated with this assertion.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 8377087 [details] [diff] [review]
v1

Review of attachment 8377087 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DrawTargetCG.cpp
@@ +412,5 @@
>                                       CGPoint *start,
>                                       double dx, double dy,
>                                       double x, double y)
>  {
> +  MOZ_ASSERT(!isinf(x) && !isinf(y));

You might consider using MFBT's mozilla::IsFinite() function.

Comment 5

[Markus Stange [:mstange]]

Push to inbound with mozilla::IsFinite() (thanks Chris):
https://hg.mozilla.org/integration/mozilla-inbound/rev/74b07332a161

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74b07332a161