973374 - complete speex_resampler_reset_mem

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P2)

Description

[Karl Tomlinson (:karlt)]

sample_frac_num is the array most likely to be non-zero after resampling a
previous stream, but the other arrays can also be left at non-zero values
in other situations.

Using a previous sample_frac_num may can mean that the first input sample is ignored.  This may usually not be significant, but may just be detectable when only one channel of a stereo signal is affected.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: patch

I still need to modify update.sh.
Please let me know if and what you'd like me to do to upstream this to
opus-tools.

Comment 2

[Karl Tomlinson (:karlt)]

(In reply to Karl Tomlinson (:karlt) from comment #0)
> Using a previous sample_frac_num may can mean that the first input sample is
> ignored.

Not ignored, but skipped.

Comment 3

[Jean-Marc Valin]

Comment on attachment 8376864 [details] [diff] [review]
patch

Review of attachment 8376864 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 4

[Karl Tomlinson (:karlt)]

With update.sh changes:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bf41db3ca50

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1bf41db3ca50