Closed
Bug 973449
Opened 11 years ago
Closed 11 years ago
[settings] refactor Do not track panel with AMD pattern
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S3 (29aug)
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
(Whiteboard: [p=2])
Attachments
(1 file)
Overview Description:
Refactor Do not track panel with AMD pattern referring to
https://github.com/crh0716/gaia/tree/settings2_iterative
to make it modularize and more easier to maintain
Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings
Expected Results:
pass all settings test and act the same as original implementation
Additional Information:
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gasolin
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8474952 -
Flags: review?(ejchen)
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [p=2]
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8474952 [details] [review]
pull request redirect to github
r+ with few nits.
Thanks Fred.
Attachment #8474952 -
Flags: review?(ejchen) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
comment addressed, merged to gaia master https://github.com/mozilla-b2g/gaia/commit/ae62df7e5cf3337a47d88a90827a5065cfa20196
thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•