Closed Bug 973452 Opened 11 years ago Closed 10 years ago

[settings] refactor Application storage panel with AMD pattern

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S4 (20june)

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

(Whiteboard: [p=5])

Attachments

(1 file)

pull request redirect to github
46 bytes, text/x-github-pull-request
arthurcc
: review+
eragonj
: feedback+
gduan
: feedback+
Details | Review
Overview Description: Refactor Application storage panel with AMD pattern referring to https://github.com/crh0716/gaia/tree/settings2_iterative to make it modularize and more easier to maintain Steps to Reproduce: 1) run make test-perf APP=settings 2) run make test-integration APP=settings Expected Results: pass all settings test and act the same as original implementation Additional Information:
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Depends on: 998847
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Whiteboard: [p=2]
Target Milestone: --- → 2.0 S2 (23may)
Wrap app storage panel to AMD pattern. DeviceStorageHelper refactor will be done in bug 998847 storage.js refator
Attachment #8422355 - Flags: review?(arthur.chen)
Comment on attachment 8422355 [details] [review] pull request redirect to github Thanks for the patch. As app storage panel works like battery panel (presents information of the device components), it would be better make the module more customizable. Detail please check my comments and the implementation of the battery panel.
Attachment #8422355 - Flags: review?(arthur.chen)
feature-b2g: --- → 2.0
Whiteboard: [p=2] → [p=5]
Comment on attachment 8422355 [details] [review] pull request redirect to github please kindly feedback for this refactor
Attachment #8422355 - Flags: feedback?(gduan)
Attachment #8422355 - Flags: feedback?(ejchen)
Comment on attachment 8422355 [details] [review] pull request redirect to github moved app_storage.js into modules, added the panel test
Attachment #8422355 - Flags: feedback?(arthur.chen)
Blocks: 998847
No longer depends on: 998847
Comment on attachment 8422355 [details] [review] pull request redirect to github Looks good to me.
Attachment #8422355 - Flags: feedback?(gduan) → feedback+
Comment on attachment 8422355 [details] [review] pull request redirect to github Please check my comments in github, thanks.
Attachment #8422355 - Flags: feedback?(arthur.chen)
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
Comment on attachment 8422355 [details] [review] pull request redirect to github Left some nits on github and bypass the review to Arthur :) thanks Fred !
Attachment #8422355 - Flags: feedback?(ejchen) → feedback+
Comment on attachment 8422355 [details] [review] pull request redirect to github issue addressed, please kindly review it again
Attachment #8422355 - Flags: review?(arthur.chen)
Comment on attachment 8422355 [details] [review] pull request redirect to github Please check my github comments, thanks.
Attachment #8422355 - Flags: review?(arthur.chen)
Based on the current status, let's take this out of 2.0.
feature-b2g: 2.0 → 2.1
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
feature-b2g: 2.1 → ---
Comment on attachment 8422355 [details] [review] pull request redirect to github I'm working on system functions last week and finally can pickup the pace. Now issue addressed and use MockDOMRequest to test freeSpace/usedSpace functions. please kindly review it again.
Attachment #8422355 - Flags: review?(arthur.chen)
Comment on attachment 8422355 [details] [review] pull request redirect to github Good work, there are last few nits to be addressed before merging. Please check them in github, thanks.
Attachment #8422355 - Flags: review?(arthur.chen)
Comment on attachment 8422355 [details] [review] pull request redirect to github nits fixed, please kindly review it again, thanks!
Attachment #8422355 - Flags: review?(arthur.chen)
Comment on attachment 8422355 [details] [review] pull request redirect to github Thank you for the effort! r=me with one last comment addressed.
Attachment #8422355 - Flags: review?(arthur.chen) → review+
merged https://github.com/mozilla-b2g/gaia/commit/818176cd36c23718161ce01c0cfa597503430e96 thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: