973458 - [settings] refactor Downloads panel with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Refactor Downloads panel with AMD pattern referring to
https://github.com/crh0716/gaia/tree/settings2_iterative

to make it modularize and more easier to maintain

Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Expected Results:

pass all settings test and act the same as original implementation

Additional Information:

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:973458-downloads-panel-amd > mozilla-b2g:master

Comment 2

[Scott Wu [:scottwu]]

Comment on attachment 8704542 [details] [review]
[gaia] scottwu:973458-downloads-panel-amd > mozilla-b2g:master

Hi Fred, I've refactored the Download panel to AMD format, would you be able to review it?

It involves quite a few scripts in both the panel and the shared folders. I have left the program logic mostly unmodified, and I haven't found any issue testing on a device (there's currently no integration test for the download panel). Please feel free to ask me if you have any question or need clarification. Thanks a lot!

Comment 3

[[e-mail]]

Comment on attachment 8704542 [details] [review]
[gaia] scottwu:973458-downloads-panel-amd > mozilla-b2g:master

generally Looks good to me, please address comments on github and set review again

Comment 4

[Scott Wu [:scottwu]]

Comment on attachment 8704542 [details] [review]
[gaia] scottwu:973458-downloads-panel-amd > mozilla-b2g:master

Thanks Fred for the feedback! I've made the changes and also fixed a small bug that caused intermittent failure in downloads_list_test.

Comment 5

[[e-mail]]

Comment on attachment 8704542 [details] [review]
[gaia] scottwu:973458-downloads-panel-amd > mozilla-b2g:master

Test fine with 1 nit, Thanks Scott!

Comment 6

[Scott Wu [:scottwu]]

Thanks a lot Fred! Merged to master.