Closed
Bug 973458
Opened 10 years ago
Closed 8 years ago
[settings] refactor Downloads panel with AMD pattern
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: scottwu)
References
Details
Attachments
(1 file)
Overview Description: Refactor Downloads panel with AMD pattern referring to https://github.com/crh0716/gaia/tree/settings2_iterative to make it modularize and more easier to maintain Steps to Reproduce: 1) run make test-perf APP=settings 2) run make test-integration APP=settings Expected Results: pass all settings test and act the same as original implementation Additional Information:
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → scwwu
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8704542 [details] [review] [gaia] scottwu:973458-downloads-panel-amd > mozilla-b2g:master Hi Fred, I've refactored the Download panel to AMD format, would you be able to review it? It involves quite a few scripts in both the panel and the shared folders. I have left the program logic mostly unmodified, and I haven't found any issue testing on a device (there's currently no integration test for the download panel). Please feel free to ask me if you have any question or need clarification. Thanks a lot!
Attachment #8704542 -
Flags: review?(gasolin)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8704542 [details] [review] [gaia] scottwu:973458-downloads-panel-amd > mozilla-b2g:master generally Looks good to me, please address comments on github and set review again
Attachment #8704542 -
Flags: review?(gasolin) → feedback+
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8704542 [details] [review] [gaia] scottwu:973458-downloads-panel-amd > mozilla-b2g:master Thanks Fred for the feedback! I've made the changes and also fixed a small bug that caused intermittent failure in downloads_list_test.
Attachment #8704542 -
Flags: review?(gasolin)
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8704542 [details] [review] [gaia] scottwu:973458-downloads-panel-amd > mozilla-b2g:master Test fine with 1 nit, Thanks Scott!
Attachment #8704542 -
Flags: review?(gasolin) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Thanks a lot Fred! Merged to master.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•