Closed Bug 973660 Opened 6 years ago Closed 6 years ago

TEST-UNEXPECTED-FAIL | AsyncPanZoomController.LongPress when touch action enabled

Categories

(Core :: Panning and Zooming, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: oleg.romashin, Assigned: alessarik)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140212131424

Steps to reproduce:

set preference 
layout.css.touch_action.enabled = true

execute gtest



Actual results:

 0:00.41 TEST-START | AsyncPanZoomController.LongPress
 0:00.41 TEST-UNEXPECTED-FAIL | AsyncPanZoomController.LongPress |
 0:00.41 Unexpected mock function call - returning directly.
 0:00.41 Function call: Call("postHandleLongTapUp")
 0:00.41 Google Mock tried the following 4 expectations, but none matched:
 0:00.41
 0:00.41 gfx/tests/gtest/TestAsyncPanZoomController.cpp:736: tried expectation #0: EXPECT_CALL(check, Call("preHandleLongTap"))...
 0:00.41 Expected: the expectation is active
 0:00.41 Actual: it is retired
 0:00.41 Expected: to be called once
 0:00.41 Actual: called once - saturated and retired
 0:00.41 gfx/tests/gtest/TestAsyncPanZoomController.cpp:738: tried expectation #1: EXPECT_CALL(check, Call("postHandleLongTap"))...
 0:00.41 Expected: the expectation is active
 0:00.41 Actual: it is retired
 0:00.41 Expected: to be called once
 0:00.41 Actual: called once - saturated and retired
 0:00.41 gfx/tests/gtest/TestAsyncPanZoomController.cpp:740: tried expectation #2: EXPECT_CALL(check, Call("preHandleLongTapUp"))...
 0:00.41 Expected arg #0: is equal to "preHandleLongTapUp"
 0:00.41 Actual: "postHandleLongTapUp"
 0:00.41 Expected: to be called once
 0:00.41 Actual: called once - saturated and active
 0:00.41 gfx/tests/gtest/TestAsyncPanZoomController.cpp:742: tried expectation #3: EXPECT_CALL(check, Call("postHandleLongTapUp"))...
 0:00.41 Expected: all pre-requisites are satisfied
 0:00.41 Actual: the following immediate pre-requisites are not satisfied:
 0:00.52 gfx/tests/gtest/TestAsyncPanZoomController.cpp:741: pre-requisite #0
 0:00.52 (end of pre-requisites)
 0:00.52 Expected: to be called once
 0:00.52 Actual: never called - unsatisfied and active @ (null):-1
 0:00.52 TEST-UNEXPECTED-FAIL | AsyncPanZoomController.LongPress | Actual function call count doesn't match EXPECT_CALL(check, Call("postHandleLongTapUp"))...
 0:00.52 Expected: to be called once
 0:00.52 Actual: never called - unsatisfied and active @ gfx/tests/gtest/TestAsyncPanZoomController.cpp:742
 0:00.52 TEST-UNEXPECTED-FAIL | AsyncPanZoomController.LongPress | Actual function call count doesn't match EXPECT_CALL(*mcc, HandleLongTapUp(CSSIntPoint(10, 10), 0, apzc->GetGuid()))...
 0:00.52 Expected: to be called once
 0:00.52 Actual: never called - unsatisfied and active @ gfx/tests/gtest/TestAsyncPanZoomController.cpp:741
 0:00.52 TEST-UNEXPECTED-FAIL | AsyncPanZoomController.LongPress | test completed (time: 4ms)
 0:00.52 TEST-START | AsyncPanZoomController.LongPressPreventDefault



Expected results:

test pass
Blocks: 970578, 795567
Status: UNCONFIRMED → NEW
Ever confirmed: true
Fail test are divided on two tests with different params
Attachment #8379619 - Flags: review?(bugmail.mozilla)
Attachment #8379619 - Flags: feedback?(nicklebedev37)
Comment on attachment 8379619 [details] [diff] [review]
repair_test_async_pan_zoom_controller

Review of attachment 8379619 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, but Doug should review too.
Attachment #8379619 - Flags: review?(drs+bugzilla)
Attachment #8379619 - Flags: review?(bugmail.mozilla)
Attachment #8379619 - Flags: review+
Comment on attachment 8379619 [details] [diff] [review]
repair_test_async_pan_zoom_controller

Sorry about the late review. I usually try to be quick with reviews, but I was bed-ridden with a really bad flu for the last 3 days.

Anyways, I tested it, and it fixed it for me. The code looks good to me too. Thanks for the fix! Would you like me to land it for you? Alternatively, you can set the "checkin-needed" keyword to summon a sheriff who will do it for you.
Attachment #8379619 - Flags: review?(drs+bugzilla) → review+
Attachment #8379619 - Flags: checkin+
I think you meant to set the checkin-needed keyword, which is at the very top of the bug in the "Keywords" section. checkin+ indicates that the patch has been landed.

Regardless, I landed it for you :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/925d3aa8a9b2
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/925d3aa8a9b2
Assignee: nobody → alessarik
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Comment on attachment 8379619 [details] [diff] [review]
repair_test_async_pan_zoom_controller

Review of attachment 8379619 [details] [diff] [review]:
-----------------------------------------------------------------

Belatedly leaving a positive feadback, sorry for delay.
Attachment #8379619 - Flags: feedback?(nicklebedev37) → review+
You need to log in before you can comment on or make changes to this bug.