Closed Bug 973744 Opened 7 years ago Closed 7 years ago

Remove matroska seek hack in the gstreamer media backend

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: alessandro.d, Assigned: alessandro.d)

Details

Attachments

(1 file, 1 obsolete file)

bug973744.patch
1.65 KB, patch
Details | Diff | Splinter Review 
::ReadMetadata has an hack to kick matroskademux in 0.10 and force it to build an index (which used to be built lazily, on the first seek). 

Since the gstreamer backend is not being used to decode matroska by default anyway, the hack makes things slightly slower for mov/h264 decoding, and since it is not needed anymore with gstreamer 1.0, I want to get rid of it.
Attached patch bug973744.patch (obsolete) — — Splinter Review
Attachment #8377325 - Flags: review?(edwin)
Keywords: checkin-needed
Doesn't apply cleanly to inbound. Please rebase.
Keywords: checkin-needed
Attached patch bug973744.patch — — Splinter Review
Keywords: checkin-needed
Attachment #8377325 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/98d81d6422dd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.