973768 - [LockScreen] Find out and fix possible failed settings in LockScreen

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

As Julien mentioned at Bug 960901, the refactored LockScreen seems has trouble in listening settings. This bug would focus on pin down the root cause and fixing them.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Can disable lockscreen

Hi, Julien: I've found the test would disable LockScreen as you mentioned, and taken a video for that. Can you check it again?

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

I still have the issue with the latest master.

Can you try by deleting your "b2g" directory so that the latest one will be downloaded?

Then, when I use master or the repository at commit "56ddd220f786916d596ea60ee170af0678d19838", I have the issue, but I don't have it anymore when I checkout the commit "56ddd220f786916d596ea60ee170af0678d19838^" (so the previous one)...

To be clear, here is what I do:

git checkout master
git fetch moz && git reset --hard moz # to get the latest one

APP=sms RUNS=1 make test-perf
# lockscreen is locked

git checkout 56ddd220f786916d596ea60ee170af0678d19838
APP=sms RUNS=1 make test-perf
# lockscreen is locked

git checkout 56ddd220f786916d596ea60ee170af0678d19838^
APP=sms RUNS=1 make test-perf
# lockscreen is disabled

git checkout master
git revert -m1 bf497b7adfaa4c087d492acf7f143a61b5ec08e9
git revert -m1 56ddd220f786916d596ea60ee170af0678d19838
# fix test conflict then
git revert --continue
APP=sms RUNS=1 make test-perf
# lockscreen is disabled

git reset --hard moz
APP=sms RUNS=1 make test-perf
# lockscreen is locked

But what's strange is that the test still works, that means marionette can still "tap"... So I really don't know what's going on, I just know that your commit definitely breaks that :(

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Ok, now I understand something better.

Now I did this:

rm -rf profile-test
RUNS=1 make test-perf

=> generates correctly a new profile

APP=sms RUNS=1 make test-perf

=> lockscreen correctly disabled

So it seems I had an old profile. I don't know what changed in bug 960901 to make it fail suddenly, and I don't know why it was not regenerated, but at least, now I am happy enough.

So I'm closing the bug, but we might want to file new ones. Not sure we'll have time for this though.

Thanks!