973790 - [B2G][Camera] Black screen while user switch camera mode.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Hubert Lu[:hlu] <[e-mail]>]

Attachment: logcat.txt

- Base ROM version -
    Gaia      bf497b7adfaa4c087d492acf7f143a61b5ec08e9
    Gecko     https://hg.mozilla.org/mozilla-central/rev/339f0d450d46
    BuildID   20140217160203
    Version   30.0a1
    ro.build.version.incremental=eng.archermind.20131114.105818
    ro.build.date=Thu Nov 14 10:58:33 CST 2013


* Reproduce Steps
1. Open the Camera app.
2. Press the Video camera icon (If default mode is video camera icon, please press picture camera icon)


* Actual results:
1. Device shows black screen while switch to another camera mode.

* Expected result:
1. Should switch to correct camera mode and viewfinder display work properly.

Comment 1

[Hubert Lu[:hlu] <[e-mail]>]

Attachment: 2014-02-18-15-11-20.png

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Unable to reproduce on Helix. What device is this happening on?

Comment 4

[gbennett]

(In reply to Mike Habicher [:mikeh] from comment #2)
> Unable to reproduce on Helix. What device is this happening on?

I am able to repro this on the latest 1.4 using a Buri device. Continuing with regression window.

Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140218040203
Gaia: ae90f9b322509ee09fbd3963bd23e142845613ab
Gecko: 318c0d6e24c5
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Comment 5

[gbennett]

.:Last Working Build:.
Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140216084847
Gaia: 33fe27aa3c60ccf312f35da0edc1b1918780379f
Gecko: 2bddbd180d2d
Version: 30.0a1
Firmware Version: v1.2-device.cfg

.:First Broken Build:.
Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140217034949
Gaia: 33fe27aa3c60ccf312f35da0edc1b1918780379f
Gecko: 364f8691ea51
Version: 30.0a1
Firmware Version: v1.2-devices.cfg

I would compare the Gecko and Gaia, but since the Gaia is the same there is no need.

Comment 6

[Jason Smith [:jsmith]]

The regression range seems incorrect. There's nothing in either regression range that would imply what this regressed. Please retest.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #6)
> The regression range seems incorrect. There's nothing in either regression
> range that would imply what this regressed. Please retest.

Actually disregard - what regressed here might not be caused by the changes in bug 958200 then.

Comment 8

[Mike Habicher [:mikeh] (high bugzilla latency)]

The camera in some devices is very picky about timing, and will stall/fail if the device is really busy. I think this is related to bug 973689.

Comment 9

[Jason Smith [:jsmith]]

(In reply to Mike Habicher [:mikeh] from comment #8)
> The camera in some devices is very picky about timing, and will stall/fail
> if the device is really busy. I think this is related to bug 973689.

I don't think so - that bug reproduces on 1.3, where as this reproduces on 1.4 only.

Comment 10

[Justin D'Arcangelo [:justindarc]]

I can reproduce this every time on Helix using latest 1.4 build from today (Wednesday 2/19). The build from Sunday (2014-02-16-16-02-03) works fine though.

Comment 11

[David Flanagan [:djf]]

When I flashed my helix with today's 1.4 engineering build I found that after the first run, the camera crashes all the time.  Starting the camera and then killing it and then restarting causes an immediate crash.  I have to reboot to get it back to a state where it doesn't crash all the time.

In that first run after a reboot, I sometimes saw the bug as described here.  Once, though, I ran it and saw the black screen right from the start and never had a working viewfinder.

Interestingly, on the first run when the viewfinder starts out okay and then goes black, I can switch back and forth between camera and video. Still all black, but the buttons are responsive.  If I then switch to gallery or the homescreen and return to the camera app, the ux is frozen and I can't switch modes.  The buttons still respond to device rotation but tapping on the does nothing.  (That seems like a clue because we have or had code that disabled the buttons while acquiring a preview).

On the other hand, my helix still displays crazy colors all the time, so I may have a very out of date base image.

Comment 12

[David Flanagan [:djf]]

I can reproduce in the same way on a hamachi with today's nightly.

Comment 13

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Only call ClearCurrentFrame() when closing down the camera hardware, v1

Comment 14

[Dave Hylands [:dhylands]]

Comment on attachment 8378695 [details] [diff] [review]
Only call ClearCurrentFrame() when closing down the camera hardware, v1

Review of attachment 8378695 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with issue addressed.

::: dom/camera/GonkCameraControl.cpp
@@ +214,5 @@
>    DOM_CAMERA_LOGT("%s:%d\n", __func__, __LINE__);
>    MOZ_ASSERT(NS_GetCurrentThread() == mCameraThread);
>  
>    // Stop any currently running preview
> +  PausePreview();

I noticed this is declared to return an nsresult, which is apparently being ignored.

should this check the value? or perhaps PausePreview should be declared void?

Comment 15

[Mike Habicher [:mikeh] (high bugzilla latency)]

try-server push: https://tbpl.mozilla.org/?tree=Try&rev=7b84eb4f5490&showall=1

Comment 16

[Dave Hylands [:dhylands]]

Comment on attachment 8378695 [details] [diff] [review]
Only call ClearCurrentFrame() when closing down the camera hardware, v1

Review of attachment 8378695 [details] [diff] [review]:
-----------------------------------------------------------------

Oops set the wrong flag

Comment 17

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Dave Hylands [:dhylands] from comment #14)
> Comment on attachment 8378695 [details] [diff] [review]
> Only call ClearCurrentFrame() when closing down the camera hardware, v1
> 
> Review of attachment 8378695 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with issue addressed.
> 
> ::: dom/camera/GonkCameraControl.cpp
> @@ +214,5 @@
> >    DOM_CAMERA_LOGT("%s:%d\n", __func__, __LINE__);
> >    MOZ_ASSERT(NS_GetCurrentThread() == mCameraThread);
> >  
> >    // Stop any currently running preview
> > +  PausePreview();
> 
> I noticed this is declared to return an nsresult, which is apparently being
> ignored.
> 
> should this check the value? or perhaps PausePreview should be declared void?

Sure, I'll change it to a void return.

Comment 18

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Only call ClearCurrentFrame() when closing down the camera hardware, v2, r=dhylands

Carrying r+ forward.
aggregate try-server push: https://tbpl.mozilla.org/?tree=Try&rev=7b84eb4f5490&showall=1

Comment 19

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Only call ClearCurrentFrame() when closing down the camera hardware, v2.1, r=dhylands

Carrying r+ forward; putting the nsresult return type back in, and logging a warning on failure.

Comment 20

[Hubert Lu[:hlu] <[e-mail]>]

This bug is happened in Buri device.

Comment 21

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://hg.mozilla.org/integration/b2g-inbound/rev/8a58bb59c57f

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a58bb59c57f

Comment 23

[Natalya Kot [:nkot]]

Verified fixed.
Can switch to correct camera mode and viewfinder display work properly.

BuildID: 20140221040202
Gaia: 35365feace970bfc51276428f40a477c9c86b7bb
Gecko: 7010ab83a06e
Version: 30.0a1
v1.2-devices.cfg