Closed Bug 973818 Opened 6 years ago Closed 6 years ago

[mozprofile] Disable first run content overlay in metro mode

Categories

(Testing :: Mozbase, defect, major)

All
Windows 8.1
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: AndreeaMatei, Assigned: AndreeaMatei)

References

Details

(Whiteboard: [mozmill-2.0.6+])

Attachments

(1 file, 1 obsolete file)

A new overlay has been introduced with the build from February 15th, when you open the browser for the first time, in metro mode, and try to navigate to a page, you get a layer which explains where the tabs container has gone, the location bar, what are the buttons on the sides. 
It also has a "Got it" button which will make it disappear if tapped. 

The preference for this is: browser.firstrun-content.dismissed
http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/browser-ui.js#1222

I'll work on a patch shortly, we need it as all of our tests for metro are blocked by this.
Given that this blocks all of our testing for Metro, we need this fix for Mozmill 2.0.6.
Severity: normal → major
Summary: Disable first run content overlay in metro mode → [mozprofile] Disable first run content overlay in metro mode
Whiteboard: [mozmill-2.0.6+]
Attached patch patch v1 (obsolete) — Splinter Review
Setting the preference to true is dismissing the overlay.
Attachment #8377503 - Flags: review?(hskupin)
Comment on attachment 8377503 [details] [diff] [review]
patch v1

Review of attachment 8377503 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine but please update the patch so it works on top of mozilla-central. The github repository has been closed, and the files can be found in testing/mozbase now. Also we should bump the version in this patch. Make sure that dependencies are fixed and mozrunner picks it up.
Attachment #8377503 - Flags: review?(hskupin) → review+
Depends on: 949600
Attached patch patch v2Splinter Review
Uses latest mozilla-central, bumped version and ran setup_development to see 0.21 version was taken.
Attachment #8377503 - Attachment is obsolete: true
Attachment #8378982 - Flags: review?(hskupin)
Comment on attachment 8378982 [details] [diff] [review]
patch v2

Review of attachment 8378982 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I will push to try in a bit.
Attachment #8378982 - Flags: review?(hskupin) → review+
Given that MetroFirefoxProfile is not used anywhere on m-c I pushed this change directly to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1664bf0e431
Flags: in-testsuite-
Keywords: leave-open
Target Milestone: --- → mozilla30
mozprofile 0.21 has been released:

Submitting dist/mozprofile-0.21.tar.gz to http://pypi.python.org/pypi
Server response (200): OK
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: leave-open
Resolution: --- → FIXED
Andreea, to make this work we do not need mozmill 2.0.6. I have updated the mozmill-env so it includes mozprofile 0.21 now. Please grab a copy from mozqa.com. It should unblock you from running Metro tests in your local Mozmill CI.
Great Henrik, thanks!
You need to log in before you can comment on or make changes to this bug.