973818 - [mozprofile] Disable first run content overlay in metro mode

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andreea Matei [:AndreeaMatei]]

A new overlay has been introduced with the build from February 15th, when you open the browser for the first time, in metro mode, and try to navigate to a page, you get a layer which explains where the tabs container has gone, the location bar, what are the buttons on the sides. 
It also has a "Got it" button which will make it disappear if tapped. 

The preference for this is: browser.firstrun-content.dismissed
http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/browser-ui.js#1222

I'll work on a patch shortly, we need it as all of our tests for metro are blocked by this.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Given that this blocks all of our testing for Metro, we need this fix for Mozmill 2.0.6.

Comment 2

[Andreea Matei [:AndreeaMatei]]

Attachment: patch v1

Setting the preference to true is dismissing the overlay.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8377503 [details] [diff] [review]
patch v1

Review of attachment 8377503 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine but please update the patch so it works on top of mozilla-central. The github repository has been closed, and the files can be found in testing/mozbase now. Also we should bump the version in this patch. Make sure that dependencies are fixed and mozrunner picks it up.

Comment 4

[Andreea Matei [:AndreeaMatei]]

Attachment: patch v2

Uses latest mozilla-central, bumped version and ran setup_development to see 0.21 version was taken.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8378982 [details] [diff] [review]
patch v2

Review of attachment 8378982 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I will push to try in a bit.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Given that MetroFirefoxProfile is not used anywhere on m-c I pushed this change directly to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1664bf0e431

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f1664bf0e431

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

mozprofile 0.21 has been released:

Submitting dist/mozprofile-0.21.tar.gz to http://pypi.python.org/pypi
Server response (200): OK

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Andreea, to make this work we do not need mozmill 2.0.6. I have updated the mozmill-env so it includes mozprofile 0.21 now. Please grab a copy from mozqa.com. It should unblock you from running Metro tests in your local Mozmill CI.

Comment 10

[Andreea Matei [:AndreeaMatei]]

Great Henrik, thanks!