Closed Bug 973937 Opened 6 years ago Closed 6 years ago

[mozcrash] check_for_crashes() doesn't save .extra file to dump_save_path

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill-2.0.6+])

Attachments

(1 file)

Patch v1
7.52 KB, patch
ted
: review+
Details | Diff | Splinter Review 
At the moment only the .dmp file is getting saved to the specified dump_save_path. But to let the crash reporter send the crash information also the corresponding .extra file is needed.
I will take this given that we need this fixed for Mozmill 2.0.6.
Assignee: nobody → hskupin
Blocks: 971796
Status: NEW → ASSIGNED
Whiteboard: [mozmill-2.0.6+]
Attached patch Patch v1 — — Splinter Review 
That updates mozcrash to also safe off the .extra file if existent. The patch also adds tests. I will push to try in a bit, but feel free to review already.
Attachment #8377683 - Flags: review?(ted)
Attachment #8377683 - Flags: review?(ted) → review+
I cannot land those bits given that we need the merge of mozbase done via bug 949600.
Depends on: 949600
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dea7efc7515

Please leave the bug open because I have to release a new version of mozcrash.
Flags: in-testsuite+
Keywords: leave-open
Target Milestone: --- → mozilla30
mozcrash 0.12 has been released to pypi:

running upload
Submitting dist/mozcrash-0.12.tar.gz to http://pypi.python.org/pypi
Server response (200): OK
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.