Closed
Bug 973941
Opened 11 years ago
Closed 11 years ago
Background image request follow-up
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Firefox OS Graveyard
Gaia::Search
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
Addressing comments from bug 972163.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8377624 [details] [review]
Github pull request
Amir - I think this is ready to go. Could you give me an example of a search term that would actually leverage this? (I could not tell a difference before and after implementing it, so I wanted to make sure it actually works).
Thanks!
Attachment #8377624 -
Flags: review?(amirn)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8377624 [details] [review]
Github pull request
without the patch:
E/GeckoConsole( 4989): Content JS LOG at app://search.gaiamobile.org/js/providers/bgimage.js:63 in resolve: response.image.data.length=22828
with the patch:
E/GeckoConsole( 4908): Content JS LOG at app://search.gaiamobile.org/js/providers/bgimage.js:69 in resolve: response.image.data.length=21520
Thanks.
Attachment #8377624 -
Flags: review?(amirn) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•