Closed
Bug 973961
Opened 12 years ago
Closed 12 years ago
URLs visited with search results have "?search=..." on them and should not
Categories
(developer.mozilla.org Graveyard :: General, defect)
developer.mozilla.org Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sheppy, Assigned: jezdez)
References
Details
Similar to the "?redirect=" thing we just fixed, this needs to go away, as the cruft clutters up content shared on twitter, on other wikis, blogs, etc. Yeah, the URLs work, but they're sloppy and we will be getting complaints just like we did about the redirects.
Comment 1•12 years ago
|
||
I've temporarily disabled the feature until we fix this.
Context: This is for the docs navigator feature. We store the user's search results into a localstorage item and use the ?search={id} to get the results back out without having to re-query the search backend.
Options:
* Move the id to a session variable - makes the feature logged-in-only :(
* Move the id to a per-tab cookie - adds significant state to requests :(
* Re-request the search results on the article pages - adds an extra request :(
Of these options, I lean towards the latter: we have a search API endpoint that doesn't suffer the same HTML-parsing performance issues as other MDN endpoints, so an asynchronous request shouldn't be too bad.
:habber, :sheppy, :jezdez ?
Flags: needinfo?(jezdez)
Flags: needinfo?(hhabstritt.bugzilla)
Flags: needinfo?(eshepherd)
| Reporter | ||
Comment 2•12 years ago
|
||
Yeah, I agree -- as much of a bummer as it is to do a new search result request, it's the most effective option.
Flags: needinfo?(eshepherd)
| Assignee | ||
Comment 3•12 years ago
|
||
Yeah, so this is a huge bummer, but I agree we can only roll forward with this.
I've started implementing the third option and think it's the best way to scale this in any case -- especially with regard to what we have in mind for the upcoming iterations of the feature (population the navigator when coming from Google instead of our own search result page).
Assignee: nobody → jezdez
Flags: needinfo?(jezdez)
Comment 4•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/kuma
https://github.com/mozilla/kuma/commit/90e76754c492031e029a3726e0d8c2a5bfb05b8e
Fix bug 973961 - remove search param from search navigator URLs
This stores search results temporarily in session storage instead of
local storage. The empty session storage is filled on the first result
page that is clicked on via an AJAX request.
https://github.com/mozilla/kuma/commit/ddee81f800b9b81a280a3cbff77673104d787990
Merge pull request #2073 from jezdez/search-navigator-refactor
Fix bug 973961 - remove search parameter from document URLs
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
Comment 5•1 month ago
|
||
Clearing the needinfo request since this bug has been moved to the developer.mozilla.org Graveyard product.
For more information, please visit BugBot documentation.
Flags: needinfo?(hhabstritt.bugzilla)
You need to log in
before you can comment on or make changes to this bug.
Description
•