974069 - Create an emulator-jb specific mochitest manifest for running b2g multimedia tests

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Andrew Halberstadt [:ahal]]

Something like:

testing/mochitest/manifests/emulator-jb.ini

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Set to default, I'm not sure this one means I should separate the mochitest for jb and ics in media test case.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - add emulator jb manifest

Pretty sure adding new Makefiles needs build peer review.

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8380762 [details] [diff] [review]
Patch 1.0 - add emulator jb manifest

Review of attachment 8380762 [details] [diff] [review]:
-----------------------------------------------------------------

Apparently using ':ted' doesn't work anymore..

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8380762 [details] [diff] [review]
Patch 1.0 - add emulator jb manifest

Review of attachment 8380762 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/manifests/Makefile.in
@@ +4,5 @@
> +
> +STATIC_FILES = emulator-jb.ini \
> +		$(NULL)
> +STATIC_DEST = $(DEPTH)/_tests/$(relativesrcdir)
> +INSTALL_TARGETS += STATIC

Having spent most of the last week removing Makefiles like this this makes me a little sad, but we don't have a better solution for this yet. I'll fix that soon, I guess.

Comment 5

[Andrew Halberstadt [:ahal]]

Sorry :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/68cb672eba84

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/68cb672eba84

Comment 7

[Andrew Halberstadt [:ahal]]

This got overwritten by ted's patch in bug 977699:
http://hg.mozilla.org/mozilla-central/diff/dfe7b9b49fc8/testing/mochitest/moz.build

Ted, I see you have gotten rid of all the makefiles under testing/mochitest except for the one introduced by this bug. I'd be fine re-doing this to not use a Makefile, I'm just not really sure how. Essentially I just want the 'manifests' directory to be copied to the test package, but I'm not sure if I should copy the mochitest.ini 'support-files' method you used for other directories. A mochitest manifest listing other mochitest manifests as support files seems kind of weird.

Comment 8

[Andrew Halberstadt [:ahal]]

Talked to ted on irc. He said to just add 'manifests' back to the DIRS variable for now. Patch coming soon.

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Add 'manifests' back to DIRS

<ahal> ted: ok, so do I have irc r+ on just adding 'manifests' back to the DIRS variable?
<ted> ahal: yeah, r=me

https://hg.mozilla.org/integration/mozilla-inbound/rev/596afdd963e7

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/596afdd963e7