Closed Bug 974069 Opened 6 years ago Closed 6 years ago

Create an emulator-jb specific mochitest manifest for running b2g multimedia tests

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(2 files)

Something like:

testing/mochitest/manifests/emulator-jb.ini
Assignee: nobody → rlin
Set to default, I'm not sure this one means I should separate the mochitest for jb and ics in media test case.
Assignee: rlin → nobody
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Pretty sure adding new Makefiles needs build peer review.
Attachment #8380762 - Flags: review?
Comment on attachment 8380762 [details] [diff] [review]
Patch 1.0 - add emulator jb manifest

Review of attachment 8380762 [details] [diff] [review]:
-----------------------------------------------------------------

Apparently using ':ted' doesn't work anymore..
Attachment #8380762 - Flags: review? → review?(ted)
Comment on attachment 8380762 [details] [diff] [review]
Patch 1.0 - add emulator jb manifest

Review of attachment 8380762 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/manifests/Makefile.in
@@ +4,5 @@
> +
> +STATIC_FILES = emulator-jb.ini \
> +		$(NULL)
> +STATIC_DEST = $(DEPTH)/_tests/$(relativesrcdir)
> +INSTALL_TARGETS += STATIC

Having spent most of the last week removing Makefiles like this this makes me a little sad, but we don't have a better solution for this yet. I'll fix that soon, I guess.
Attachment #8380762 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/68cb672eba84
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
This got overwritten by ted's patch in bug 977699:
http://hg.mozilla.org/mozilla-central/diff/dfe7b9b49fc8/testing/mochitest/moz.build

Ted, I see you have gotten rid of all the makefiles under testing/mochitest except for the one introduced by this bug. I'd be fine re-doing this to not use a Makefile, I'm just not really sure how. Essentially I just want the 'manifests' directory to be copied to the test package, but I'm not sure if I should copy the mochitest.ini 'support-files' method you used for other directories. A mochitest manifest listing other mochitest manifests as support files seems kind of weird.
Status: RESOLVED → REOPENED
Depends on: 977699
Flags: needinfo?(ted)
Resolution: FIXED → ---
Talked to ted on irc. He said to just add 'manifests' back to the DIRS variable for now. Patch coming soon.
Flags: needinfo?(ted)
<ahal> ted: ok, so do I have irc r+ on just adding 'manifests' back to the DIRS variable?
<ted> ahal: yeah, r=me

https://hg.mozilla.org/integration/mozilla-inbound/rev/596afdd963e7
Attachment #8389285 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/596afdd963e7
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.