Closed Bug 974072 Opened 6 years ago Closed 6 years ago

Only restore breakpoints if there are breakpoints in the breakpointStore

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 30

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

It doesn't make sense to call findScripts and findBreakpoints if we don't even have any breakpoints in the store. This saves about 15-20 ms on startup time on my machine.
Attachment #8377774 - Flags: review?(past)
Comment on attachment 8377774 [details] [diff] [review]
restore-breakpoints.patch

Review of attachment 8377774 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8377774 - Flags: review?(past) → review+
https://hg.mozilla.org/integration/fx-team/rev/e984f0667981
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e984f0667981
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.