Closed Bug 974087 Opened 10 years ago Closed 10 years ago

Investigate using the new AsyncShutdown.jsm for things in SDK code.

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: KWierso, Unassigned)

References

()

Details

Over the weekend, I saw a blog post mentioning a new way of registering tasks that need to be completed before Firefox shuts down completely (like writing something to file, etc).

I know at least in the past, there was a desire to let addons register some tasks to be done on unload, but which couldn't be guaranteed to finish during Firefox shutdown. Maybe this could be used for those tasks (and possibly other things)?

From the MDN page: "If the promise returned by condition is not resolved/rejected within one minute, the process will crash to avoid blocking system shutdown, preventing the user from restarting Firefox or burning through battery. This is by design. It is the caller's responsibility to ensure that the promise is eventually resolved/rejected."

So it doesn't sound like this would allow a malicious or poorly written addon from registering tasks that would prevent Firefox from ever shutting down (any task they register would have to complete within one minute or the Firefox process crashes).

Worth investigating?
Flags: needinfo?(rFobic)
Flags: needinfo?(jgriffiths)
Flags: needinfo?(dtownsend+bugmail)
The asyncshutdown stuff happens after add-ons have already been told to exit so I don't know if we can use this in its current form.
Flags: needinfo?(dtownsend+bugmail)
Flags: needinfo?(jgriffiths)
Flags: needinfo?(rFobic)
wontfixing for now
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.