97409 - Unblocking Images from Server should be as easy as blocking images from server

Status: RESOLVED FIXED

(Core :: Graphics: Image Blocking, defect)

Description

[Rodd Clarkson]

I accidentally blocked images from a server recently.  Unfortunately unblocking
images from the same server isn't as easy.

To block them I right clicked and accidently hit Block Images from Server.
To unblock them I had to search thru the menus.  Eventually I tried preferences,
after searching various right click menus with no luck.

After searching thru the preferences I found images under security, and finally
(after looking once and missing it) the button to open another dialog to control
images viewing for particular servers.

As you can see, turn off images is infinitely easier than turning them back on.

I think that if images are turned of for a server, then option to turn them back
on needs to appear in the right click menus (and probably all of them even thou
the option to block only appears in right click menus relating to images.)

Comment 1

[Matthew T (active 1999-2002)]

Yep. Where an image is blocked, the item should change to `Unblock Images From 
this Server'. --> XP Apps: GUI.

Comment 2

[Matthew T (active 1999-2002)]

[Reassigning to component owner]

Comment 3

[Blake Ross]

--> morse

Comment 4

[Stephen P. Morse]

Attachment: Add context menu item for unblocking

Comment 5

[Stephen P. Morse]

cc'ing law and alecf for reviews

Comment 6

[Alec Flett]

Comment on attachment 53714 [details] [diff] [review]
Add context menu item for unblocking

Very nice refactoring.. just one comment:

>+        var permissionmanager =
>+          Components.classes["@mozilla.org/permissionmanager;1"]
>+            .getService().QueryInterface(Components.interfaces.nsIPermissionManager);

Can actually be:
>+        var permissionmanager =
>+          Components.classes["@mozilla.org/permissionmanager;1"]
>+            .getService(Components.interfaces.nsIPermissionManager);

(note how the interface was moved into the getService() parameters)

There's one other place where this is done, below..
with that cleanup, sr=alecf

Comment 7

[Stephen P. Morse]

Revising patch to factor out the declaration of IMAGEPERMISSION into a common 
file.  Otherwise it was defined twice (in cookieTasksOverlay and 
cookieContextOverlay) and that was causing a duplicate-definition error at 
program startup.

Also including alecf's suggestion in revised patch.

alecf, please re-review.  law, please review.

Comment 8

[Stephen P. Morse]

Attachment: avoid duplicate definition of IMAGEPERMISSION

Comment 9

[Bill Law]

Comment on attachment 53785 [details] [diff] [review]
avoid duplicate definition of IMAGEPERMISSION

r=law

Comment 10

[Alec Flett]

Comment on attachment 53785 [details] [diff] [review]
avoid duplicate definition of IMAGEPERMISSION

thanks for that extra cleanup - it avoids an extra AddRef()/Release() as well
sr=alecf

Comment 11

[Stephen P. Morse]

fix checked in