974276 - [email] Support attaching vcard files via pick and share activities

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[sync-1]

the latest id: Mozilla build ID: 20140118004002 FFOS: 1.3
 
 DEFECT DESCRIPTION:
  DUT can't view the Vcard file attachment.
  REPRODUCING PROCEDURES:
  1,Insert an roaming network ->Home->Setting->enable roaming
  2,Home->open emal->add an hotmail account ->receive some emails with attachments
  3,choose an email with Vcard file to view->DUT can't view the Vcard file attachment.(DUT can load .vcf file through sd card )->KO
 
  EXPECTED BEHAVIOUR:
  DUT can load Vcard file attachment.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:

Comment 1

[sync-1]

Attachment: Refer this picture

Comment 2

[Jason Smith [:jsmith]]

Does this reproduce on a 1.1 Buri device?

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Crap.  Bug 887663 added vcard support to the MimeMapper, which is where we get our list of supported mime types.  And it added an "import" activity that understands the mime type, but did not modify the existing "open" activity or add a new variant.

Filing a bug against contacts now.

Comment 4

[sync-1]

I think it necessary to temporarily disable the View button of Vcard file.

Comment 5

[Marina Rodríguez [:mai]]

Attachment: proposal 1.0

Hi Francisco, 
On this patch instead of invoking the open activity when the mime type is text/vcard, we invoke the import activity of the contact app, which imports the vcard before showing it.
what do you think about the patch proposed? Is this the right way?

Regards

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8461502 [details] [review]
proposal 1.0

Hi Marina,

I think this should be a product decision. IMHO, importing directly when I click on it, doesnt sounds good. I would like to check the content before deciding if we want to add it to our address book.

But again, that's my opinion. 

We do have another activity, the 'new' one, where you pass the parameters and it will fill the contacts form, that will allow  you to decide. I know that's extra work.

The last option will be to implement a view activity for a vcard in contacts, which sounds to me quite a lot of work.

Thanks

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Email could also just explicitly blacklist vcards again despite what the MimeMapper says for now.

Comment 8

[Marina Rodríguez [:mai]]

Hi Wilfred,
would you mind give us your opinion about what should be correct behaviour when an user try to open a downloaded vcard from his emaill?
Regards

Comment 9

[Wilfred Mathanaraj [:WDM]]

Have to agree with Francisco here - I would prefer to see the content before I import and save it. 
but the prod owner for email would be Sri.

Comment 10

[Fernando Campo (:fcampo)]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #6)
> 
> We do have another activity, the 'new' one, where you pass the parameters
> and it will fill the contacts form, that will allow  you to decide. I know
> that's extra work.
This could go a little crazy (if not totally unusable) if the vcard have multiple contacts in it.
> 
> The last option will be to implement a view activity for a vcard in
> contacts, which sounds to me quite a lot of work.
+1 to this, but as you say, a lot of work.
> 
> Thanks

Comment 11

[Marina Rodríguez [:mai]]

Hi, 
this bug is a dup of Bug 849729 - To support vCard 2.1 (mime-type: text/x-vCard), on the  attachment [1.5 Messages] vCard v1.0.pdf(https://bug849729.bugzilla.mozilla.org/attachment.cgi?id=8413668), is defined the expected behaviour when a open activity is called.

Regards

Comment 12

[Andrew Sutherland [:asuth] (he/him)]

Until the problem in comment 0 and acknowledged in comment 3 is addressed, we need some type of tracking bug in the email app, reopening and marking dependent on that feature bug.  If either of the contacts bugs get addressed we can then dupe this to them or resolve WFM/etc.  Most specifically, it's still potentially actionable for the email app to blacklist vcards until the contacts app is fixed.

Comment 13

[Beatriz Rodríguez [:brg]]

Testing today master build with Flame Gecko-7c8bee6 and Gaia-2f12df3, I can see vcard files attached in my mail and include them in contact app list.

Is there any bug to track the possibility to add a vcard file as attachment? or just the generic bug 848400 for attachments?

Comment 14

[James Burke [:jrburke]]

Bug 848400 seems more about attaching things to an outgoing email, where bug 825318 is more about handling other downloads. 

Bug 825318 has been used as a dupe target for getting PDF viewing, so I expect that one will be the one we use to handle non-image downloads.

Comment 15

[Andrew Sutherland [:asuth] (he/him)]

Let's morph this bug.  Now that bug 974589 is fixed and the contacts app can open the attachments (which we would already download), it's just a question of updating our manifest filter for the "share" activity to match and for our "pick" activity to likewise match the contact app's "pick" activity that returns a vcard.  Assuming there is one.  (We don't want the one that returns a contact id that we use elsewhere.)

Comment 16

[BMO Automation]

Firefox OS is not being worked on