974295 - No getPrefsByName replacement in nsIContentPrefService2

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

From bug 699859 comment 14:
> Nobody uses getPrefsByName

False. This is a useful function for preference UI, maybe not in m-c, but certainly in add-ons.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 974295-1.diff

I shall fix this bug a second time!

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 8379477 [details] [diff] [review]
974295-1.diff

Review of attachment 8379477 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, and sorry for the omission.  Ideally this would not duplicate code in _get and _commonGetStmt, but I think it's probably not worth refactoring them for it, and ContentPrefStore would have to be changed, too.

::: dom/interfaces/base/nsIContentPrefService2.idl
@@ +69,5 @@
>  
>  [scriptable, uuid(86279644-6b86-4875-a228-2d2ff2f3e33b)]
>  interface nsIContentPrefService2 : nsISupports
>  {
> +

Nit: Please remove this blank line.

@@ +76,5 @@
> +   *
> +   * @param name      The preferences' name.
> +   * @param context   The private-browsing context, if any.
> +   * @param callback  handleResult is called once for each preference unless
> +   *                  no such preference exists, in which case handleResult

no such preference exists -> no such preferences exist

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 8379477 [details] [diff] [review]
974295-1.diff

Review of attachment 8379477 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/base/nsIContentPrefService2.idl
@@ +66,5 @@
>   *
>   * See nsIContentPrefCallback2 below for more information about callbacks.
>   */
>  
>  [scriptable, uuid(86279644-6b86-4875-a228-2d2ff2f3e33b)]

Oh, this UUID needs to be updated, too.  r+ with that.

Comment 4

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b59ba1ae73e

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9b59ba1ae73e