Closed Bug 974296 Opened 11 years ago Closed 11 years ago

Facebook Link view is broken

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.4 S3 (14mar)

People

(Reporter: jmcf, Assigned: paco)

Details

Attachments

(3 files)

2014-02-19-09-15-29.png
33.74 KB, image/png
Details
Contact Facebook views fixed (css)
46 bytes, text/x-github-pull-request
jmcf
: review-
Details | Review
Patch in github
46 bytes, text/x-github-pull-request
jmcf
: review+
Details | Review
Attached image 2014-02-19-09-15-29.png —
see attachment
there is an spurious blank space on the top that shouldn't be there
Assignee: nobody → jmcf
Assignee: jmcf → contacto
Sending pull request with the fix :)
Please, could you review the code? Regards.
Attachment #8380596 - Flags: review?(jmcf)
Attachment #8380596 - Flags: review?(jmcf)
Comment on attachment 8380596 [details] [review] Contact Facebook views fixed (css) handing over review to Arnau
Attachment #8380596 - Flags: review?(arnau)
Attachment #8380596 - Flags: review?(arnau) → review-
Assignee: contacto → pacorampas
Attached file Patch in github —
Attachment #8388415 - Flags: review?(jmcf)
Comment on attachment 8388415 [details] [review] Patch in github perfect! thanks Paco
Attachment #8388415 - Flags: review?(jmcf) → review+
landed in master: https://github.com/mozilla-b2g/gaia/commit/3a5752dfcd907f5445d5a762fde11462743d2141
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S3 (14mar)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: